Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): pass event to useRuntimeConfig in Nuxt renderer #26058

Merged
merged 1 commit into from Mar 4, 2024

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #25925

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

This attempts to address an issue with runtime config in Cloudflare. Note that this may not fully resolve the issue if there are upstream issues or lack of support within Cloudflare:

Passing event explicitly when possible is good idea.

Also related: unjs/nitro#2054

(in general, I'm afraid only safe point we can say cloudflare pages supports env universally, is when we can opt into Async Context)
-- @pi0

However, by making this change, useRuntimeConfig() within the Vue app does not need to receive the event parameter as it will fall back to the already resolved config set in this PR.

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

Copy link

stackblitz bot commented Mar 3, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe changed the title fix(nuxt): pass event to useRuntimeConfig fix(nuxt): pass event to useRuntimeConfig in renderer routes Mar 3, 2024
@danielroe danielroe changed the title fix(nuxt): pass event to useRuntimeConfig in renderer routes fix(nuxt): pass event to useRuntimeConfig in Nuxt renderer Mar 3, 2024
@danielroe danielroe merged commit 2e1530c into main Mar 4, 2024
37 checks passed
@danielroe danielroe deleted the fix/runtime-config-event branch March 4, 2024 11:37
@github-actions github-actions bot mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime config environment variables do not override default values with cloudflare-pages preset
1 participant