Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(nuxt): use faster approach to check cache exists #26172

Merged
merged 1 commit into from
Mar 10, 2024
Merged

perf(nuxt): use faster approach to check cache exists #26172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/nuxt/src/app/composables/asyncData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ export function useAsyncData<
console.warn('[nuxt] `boolean` values are deprecated for the `dedupe` option of `useAsyncData` and will be removed in the future. Use \'cancel\' or \'defer\' instead.')
}

const hasCachedData = () => ![null, undefined].includes(options.getCachedData!(key) as any)
const hasCachedData = () => options.getCachedData!(key) != null
danielroe marked this conversation as resolved.
Show resolved Hide resolved

// Create or use a shared asyncData entity
if (!nuxtApp._asyncData[key] || !options.immediate) {
Expand Down