fix(nuxt): don't append new route for redirect if one exists

packages/nuxt/src/pages/module.ts

@@ -12,7 +12,7 @@ import type { EditableTreeNode, Options as TypedRouterOptions } from 'unplugin-v
 import type { NitroRouteConfig } from 'nitropack'
 import { defu } from 'defu'
 import { distDir } from '../dirs'
-import { normalizeRoutes, resolvePagesRoutes } from './utils'
+import { normalizeRoutes, resolvePagesRoutes, resolveRoutePaths } from './utils'
 import { extractRouteRules, getMappedPages } from './route-rules'
 import type { PageMetaPluginOptions } from './plugins/page-meta'
 import { PageMetaPlugin } from './plugins/page-meta'
@@ -371,9 +371,13 @@ export default defineNuxtModule({
       // when the app manifest is enabled.
       nuxt.hook('pages:extend', (routes) => {
         const nitro = useNitro()
+        let resolvedRoutes: string[]
         for (const path in nitro.options.routeRules) {
           const rule = nitro.options.routeRules[path]
           if (!rule.redirect) { continue }
+          resolvedRoutes ||= routes.flatMap(route => resolveRoutePaths(route))
+          // skip if there's already a route matching this path
+          if (resolvedRoutes.includes(path)) { continue }
           routes.push({
             _sync: true,
             path: path.replace(/\/[^/]*\*\*/, '/:pathMatch(.*)'),

packages/nuxt/src/pages/utils.ts

@@ -197,7 +197,7 @@
       try {
         extractedMeta[key] = JSON.parse(runInNewContext(`JSON.stringify(${valueString})`, {}))
       } catch {
         console.debug(`[nuxt] Skipping extraction of \`${key}\` metadata as it is not JSON-serializable (reading \`${absolutePath}\`).`)
         dynamicProperties.add(key)
         continue
       }
@@ -210,7 +210,7 @@
           continue
         }
         if (element.type !== 'Literal' || typeof element.value !== 'string') {
           console.debug(`[nuxt] Skipping extraction of \`${key}\` metadata as it is not an array of string literals (reading \`${absolutePath}\`).`)
           dynamicProperties.add(key)
           continue
         }
@@ -221,7 +221,7 @@
     }
 
     if (property.value.type !== 'Literal' || typeof property.value.value !== 'string') {
       console.debug(`[nuxt] Skipping extraction of \`${key}\` metadata as it is not a string literal or array of string literals (reading \`${absolutePath}\`).`)
       dynamicProperties.add(key)
       continue
     }
@@ -539,3 +539,10 @@
 
   return path.replace(/\/(?:[^:/]+)?:\w+.*$/, '/**')
 }
+
+export function resolveRoutePaths (page: NuxtPage, parent = '/'): string[] {
+  return [
+    joinURL(parent, page.path),
+    ...page.children?.flatMap(child => resolveRoutePaths(child, joinURL(parent, page.path))) || []
+  ]
+}

test/fixtures/basic-types/nuxt.config.ts

@@ -30,6 +30,11 @@ export default defineNuxtConfig({
       val: 1
     }
   },
+  routeRules: {
+    '/param': {
+      redirect: '/param/1'
+    }
+  },
   modules: [
     function () {
       addTypeTemplate({

test/fixtures/basic-types/pages/param.vue

@@ -0,0 +1,5 @@
+<template>
+  <div>
+    <!--  -->
+  </div>
+</template>