Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nuxt): call useState in setup function in NuxtClientFallback #26928

Merged
merged 1 commit into from Apr 27, 2024

Conversation

huang-julien
Copy link
Member

馃敆 Linked issue

#24135

馃摎 Description

Hi 馃憢 this PR probably fix the memory leak issue in NuxtClientFallback server side.

Copy link

stackblitz bot commented Apr 24, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@huang-julien
Copy link
Member Author

huang-julien commented Apr 24, 2024

I don't have the time to test this now with k6 and a bigger project. If someone has a larger project, you're welcome to try this PR!
you can patch your local nuxt or we can make a pr release

cc @danielroe

@danielroe
Copy link
Member

/trigger release

Copy link
Contributor

馃殌 Release triggered! You can now install nuxt@npm:nuxt-nightly@pr-26928

@huang-julien huang-julien marked this pull request as ready for review April 26, 2024 15:27
@danielroe danielroe merged commit 4544eaf into main Apr 27, 2024
37 checks passed
@danielroe danielroe deleted the fix/clientfallback_memleak branch April 27, 2024 20:01
@github-actions github-actions bot mentioned this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants