Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: try enable regexp eslint rules #27207

Merged
merged 4 commits into from
May 14, 2024
Merged

Conversation

antfu
Copy link
Member

@antfu antfu commented May 14, 2024

To give a quick overview of how these rules would affect our repo.

Commits:

Copy link

stackblitz bot commented May 14, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

socket-security bot commented May 14, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/ignore@5.3.1 None 0 51.5 kB kael
npm/jiti@1.21.0 environment, filesystem, unsafe 0 1.91 MB pi0

View full report↗︎

packages/ui-templates/lib/render.ts Dismissed Show resolved Hide resolved
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid to me - thank you so much! - and I'm happy to go ahead and merge if you like, so we don't end up with a PR that will be tricky to resolve conflicts on later 🙏

@danielroe danielroe merged commit b96b62e into main May 14, 2024
62 checks passed
@danielroe danielroe deleted the chore/enable-eslint-regex branch May 14, 2024 17:54
@github-actions github-actions bot mentioned this pull request May 14, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants