Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: access to pages with non ascii filenames #3841

Closed
wants to merge 2 commits into from

Conversation

aldarund
Copy link

@aldarund aldarund commented Sep 3, 2018

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves: #2888 #3211

Blocked by: vuejs/vue-router#2375

Waiting for vue-router release > 3.0.1 before we can merge this

As a workaround dynamic url with slug can be used e.g. mypage/_slug.vue. In this case any url mypage/* even if it contains non ascii chars will be rendered.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests passed.

@codecov-io
Copy link

codecov-io commented Sep 3, 2018

Codecov Report

Merging #3841 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev   #3841   +/-   ##
=====================================
  Coverage   97.8%   97.8%           
=====================================
  Files         18      18           
  Lines       1183    1183           
  Branches     325     325           
=====================================
  Hits        1157    1157           
  Misses        25      25           
  Partials       1       1
Impacted Files Coverage Δ
lib/common/utils.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a0f094...692c13f. Read the comment docs.

@aldarund
Copy link
Author

aldarund commented Sep 4, 2018

Actually not valid solution yet :(
For some reason on first load path in route is urlencoded, but later when navigating within app not anymore..

@stale
Copy link

stale bot commented Nov 17, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Nov 17, 2018
@aldarund
Copy link
Author

ns

@stale stale bot removed the stale label Nov 17, 2018
@manniL
Copy link
Member

manniL commented Nov 23, 2018

https://github.com/vuejs/vue-router/releases/tag/v3.0.2 @aldarund

@aldarund
Copy link
Author

closing in favor of #4402

@aldarund aldarund closed this Nov 24, 2018
@lock
Copy link

lock bot commented Dec 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 25, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS execution silently fails on a statically generated site
6 participants