New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove caniuse-lite dependency #4419
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #4419 +/- ##
==========================================
+ Coverage 91.35% 91.37% +0.02%
==========================================
Files 60 60
Lines 2105 2110 +5
Branches 506 507 +1
==========================================
+ Hits 1923 1928 +5
Misses 167 167
Partials 15 15
Continue to review full report at Codecov.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Types of changes
Description
@node/server
from 12mb to 8.1mb (measured withdu -sh
, will be different when measuring with package-phobia)caniuse-lite
dependency - 3.1mb, which helps with perf/size: smaller nuxt-start size #4377browserslist-useragent
?browserslist-useragent
checks compares the user agent against some conditionals, and checks if the browser name exists inbrowser-list
(which depends oncaniuse-lite
). All we need to do is check if the user-agent browser exists inmodern-browsers.json
, and if the version isgte
to the corresponding version.modern-browsers.json
? To add the other browsers thatbrowserlist-useragent
bundled into "families", and changing the naming to matchua-parser-js
possible browser namesNotes
useragent
instead, asua-parser-js
isn't meant for browser detection.Checklist: