Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove caniuse-lite dependency #4419

Merged
merged 6 commits into from Dec 10, 2018
Merged

refactor: remove caniuse-lite dependency #4419

merged 6 commits into from Dec 10, 2018

Conversation

rlindskog
Copy link

@rlindskog rlindskog commented Nov 26, 2018

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Notes

  • It might be a good idea to use useragent instead, as ua-parser-js isn't meant for browser detection.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@rlindskog rlindskog changed the title move from browserslist-useragent to ua-parser-js / semver Remove caniuse-lite dependency Nov 26, 2018
@codecov-io
Copy link

codecov-io commented Nov 26, 2018

Codecov Report

Merging #4419 into dev will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4419      +/-   ##
==========================================
+ Coverage   91.35%   91.37%   +0.02%     
==========================================
  Files          60       60              
  Lines        2105     2110       +5     
  Branches      506      507       +1     
==========================================
+ Hits         1923     1928       +5     
  Misses        167      167              
  Partials       15       15
Impacted Files Coverage Δ
packages/server/src/middleware/modern.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2ab1b4...b548fcb. Read the comment docs.

@manniL manniL requested a review from clarkdo November 26, 2018 10:28
@clarkdo clarkdo changed the title Remove caniuse-lite dependency refactor: remove caniuse-lite dependency Nov 26, 2018
pi0
pi0 previously approved these changes Nov 26, 2018
clarkdo
clarkdo previously approved these changes Nov 26, 2018
@rlindskog rlindskog dismissed stale reviews from clarkdo and pi0 via 4def2d0 November 27, 2018 01:19
@pi0 pi0 merged commit 29c5bb6 into nuxt:dev Dec 10, 2018
@lock
Copy link

lock bot commented Jan 9, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants