fix(ts): deprecate isClient, isServer, isStatic
#5211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the documentation on the [context page](https://nuxtjs.org/api/context) and is supported by tslint
manniL
approved these changes
Mar 12, 2019
galvez
changed the title
|
CI is failing @dhritzkiv 🤔 |
|
@manniL Could someone help me understand the failures? They seem unrelated to this: audit: build: |
|
@dhritzkiv you can ignore the |
kevinmarrec
approved these changes
Mar 13, 2019
There was a problem hiding this comment.
Thanks @dhritzkiv ! Even if tslint is gonna be deprecated itself and be replaced by eslint (https://eslint.org/blog/2019/01/future-typescript-eslint / https://medium.com/palantir/tslint-in-2019-1a144c2317a9), it seems to also be understood by JSDocs so that's pretty standard, let's merge it :)
pi0
changed the title
isClient, isServer, isStatic
|
PR was targeting master :)) Cherry-picked into |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This follows the documentation on the context page and is supported by tslint.
I found this necessary as the current types were inconsistent with the documentation.
Checklist: