Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.8.0 #5765

Merged
merged 69 commits into from May 30, 2019
Merged

v2.8.0 #5765

merged 69 commits into from May 30, 2019

Conversation

pi0
Copy link
Member

@pi0 pi0 commented May 19, 2019

😎 Developer Experience

nuxt-ssr-logs-2

nuxt-hmr-indicator

πŸ› Bug Fixes

πŸš€ Features

πŸ’… Refactors

πŸ“ Examples

🏑 Chore

♻️ Tests

βš“ Dependency upgrades

πŸ’– Thanks to

@codecov-io

This comment has been minimized.

@codecov-io
Copy link

codecov-io commented May 19, 2019

Codecov Report

Merging #5765 into 2.x will increase coverage by 0.08%.
The diff coverage is 93.93%.

Impacted file tree graph

@@            Coverage Diff            @@
##             2.x    #5765      +/-   ##
=========================================
+ Coverage   95.6%   95.68%   +0.08%     
=========================================
  Files         82       82              
  Lines       2662     2690      +28     
  Branches     683      690       +7     
=========================================
+ Hits        2545     2574      +29     
  Misses        98       98              
+ Partials      19       18       -1
Flag Coverage Ξ”
#e2e 100% <ΓΈ> (?)
#fixtures 50.37% <19.69%> (?)
#unit 92.67% <93.93%> (?)
Impacted Files Coverage Ξ”
packages/config/src/config/_common.js 100% <ΓΈ> (ΓΈ) ⬆️
packages/config/src/config/build.js 100% <ΓΈ> (ΓΈ) ⬆️
packages/builder/src/context/template.js 100% <ΓΈ> (ΓΈ) ⬆️
packages/utils/src/serialize.js 92.85% <ΓΈ> (ΓΈ) ⬆️
packages/webpack/src/config/base.js 94.94% <ΓΈ> (ΓΈ) ⬆️
packages/vue-app/src/index.js 0% <ΓΈ> (ΓΈ) ⬆️
packages/config/src/config/render.js 100% <ΓΈ> (ΓΈ) ⬆️
packages/cli/src/commands/build.js 86.36% <0%> (ΓΈ) ⬆️
packages/generator/src/generator.js 100% <100%> (ΓΈ) ⬆️
packages/config/src/options.js 100% <100%> (ΓΈ) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 0f609df...2e41bb4. Read the comment docs.

@Atinux Atinux mentioned this pull request May 29, 2019
@Atinux
Copy link
Member

Atinux commented May 29, 2019

Docs PR: nuxt/docs#1421

Pooya Parsa and others added 13 commits May 29, 2019 16:44
* feat: inline HMR progress indicator

* support router base

* fix nuxt err

* fix space

* fix indentation

* return in case of ws message parsing error

* close ws on beforeDestroy

* ui: Update loading indicator UI

* builder: Add build.indicator option

* ui: Use only logo and %

* hotfix: Alphabetical order

* hotfix: Add fixed with and add back v-if

* minor style change

* rename component to build-indicator

* feat: animated progress

* assign name to component

* update test

* naming consistency

* render into app to prevent dom wrapping

* extra new line

* better App.js formatting

* update snapshot

* clear interval
* separately log mount error in dev mode
* simplify mount exception

Co-authored-by: Xin Du (Clark) <clark.duxin@gmail.com>
@pi0 pi0 merged commit e33cc71 into 2.x May 30, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet