Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webpack): add mjs to babel-loader #7178

Merged
merged 2 commits into from Apr 5, 2020
Merged

feat(webpack): add mjs to babel-loader #7178

merged 2 commits into from Apr 5, 2020

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Apr 5, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Close #6688

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested review from pi0 and a team April 5, 2020 11:17
@clarkdo clarkdo self-assigned this Apr 5, 2020
@codecov-io
Copy link

Codecov Report

Merging #7178 into dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7178   +/-   ##
=======================================
  Coverage   62.82%   62.82%           
=======================================
  Files          84       84           
  Lines        3400     3400           
  Branches      928      928           
=======================================
  Hits         2136     2136           
  Misses       1017     1017           
  Partials      247      247           
Flag Coverage Δ
#unittests 62.82% <ø> (ø)
Impacted Files Coverage Δ
packages/webpack/src/config/base.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21b39fc...512c92c. Read the comment docs.

@pi0 pi0 merged commit 16b9c15 into dev Apr 5, 2020
@pi0 pi0 deleted the feat/babel-mjs branch April 5, 2020 13:41
@pi0 pi0 mentioned this pull request Jun 10, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't transpile module which using .mjs extension
4 participants