Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: setFoldrs caused payload loading errors #7692

Closed
wants to merge 2 commits into from
Closed

fix: setFoldrs caused payload loading errors #7692

wants to merge 2 commits into from

Conversation

idler8
Copy link

@idler8 idler8 commented Jul 9, 2020

setFoldrs caused payload loading errors
This is a temporary fix
#7559 #7622

I think the problem is here, but I still don’t know the design intent here.
https://github.com/nuxt/nuxt.js/blob/99432d5d945c888fdea59094b96349397882af8e/packages/generator/src/generator.js#L365

setFoldrs caused payload loading errors
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2020

Codecov Report

Merging #7692 into dev will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #7692   +/-   ##
=======================================
  Coverage   70.13%   70.13%           
=======================================
  Files          88       88           
  Lines        3764     3764           
  Branches     1025     1025           
=======================================
  Hits         2640     2640           
  Misses        913      913           
  Partials      211      211           
Flag Coverage Δ
#unittests 70.13% <0.00%> (ø)
Impacted Files Coverage Δ
packages/vue-renderer/src/renderers/ssr.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 124cb09...ddd1ddb. Read the comment docs.

@idler8 idler8 changed the title fix bug setFoldrs caused payload loading errors fix: setFoldrs caused payload loading errors Jul 9, 2020
@pi0
Copy link
Member

pi0 commented Jul 10, 2020

Hi, @idler8 thanks for pull request. Actually linked issue #7559 is fixed with v2.13.3 (PR: #7657) (also related #7648)

For this fix and #7622, we also need a reproduction to confirm both bug and fix before merge.

Update: I can see issue with index.html but it is not happening on renderer but runtime so maybe need fixing here: https://github.com/nuxt/nuxt.js/blob/124cb0994a81029081b60345e93ba433d65b8d8e/packages/vue-app/template/App.js#L298

@idler8
Copy link
Author

idler8 commented Jul 10, 2020

I did not find a place where I could get the setFolders parameter when rendering.
I think this is a design flaw with inconsistent [route].
You can take a look at the repair suggestions on my issue.
The Nuxt.js code is confusing in my opinion, lacking comments, I have no ability to fix it fundamentally, surface corrections will only cause bigger problems.
@pi0 thanks.

@idler8 idler8 closed this Jul 10, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants