fix: modules duplicated in multiple chunks now are always loaded by runtime.js

[maunier]

Types of changes

• Bug fix (a non-breaking change which fixes an issue)
• New feature (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

Here is the issue: vuejs/vue#11560
Sorry I have maken the issue at wrong place.

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly. (PR: #)
• I have added tests to cover my changes (if not applicable, please state why)
• All new and existing tests are passing.

[codecov-commenter]

Codecov Report

Merging #7856 into dev will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev    #7856      +/-   ##
==========================================
+ Coverage   68.88%   68.89%   +0.01%     
==========================================
  Files          90       90              
  Lines        3840     3839       -1     
  Branches     1038     1037       -1     
==========================================
  Hits         2645     2645              
  Misses        971      971              
+ Partials      224      223       -1     

Flag	Coverage Δ
#unittests	68.89% <0.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/webpack/src/plugins/vue/client.js	3.70% <0.00%> (+0.06%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c30499d...179ef35. Read the comment docs.

[clarkdo]

Is the only change removing m.chunks.length === 1 ?

[maunier]

Is the only change removing m.chunks.length === 1 ?

Yes

[clarkdo]

This plugin is cloned from vue, so would you mind opening an issue there ? https://github.com/vuejs/vue/blob/4dec3b52c9b71f816e6b86d42ea53e9f2e559646/src/server/webpack-plugin/client.js#L40

I think introducing multiple chunks may need more analyse and data processing, I'll take a deep look about the change.

[maunier]

This plugin is cloned from vue, so would you mind opening an issue there ? https://github.com/vuejs/vue/blob/4dec3b52c9b71f816e6b86d42ea53e9f2e559646/src/server/webpack-plugin/client.js#L40

I think introducing multiple chunks may need more analyse and data processing, I'll take a deep look about the change.

ok, thanks

[clarkdo]

BTW, can you please provide me a minimal reproduciable repo about this issue ?

[maunier]

BTW, can you please provide me a minimal reproduciable repo about this issue ?

Yes: https://github.com/maunier/test-vue-ssr.git

[galvez]

@maunier Any reason not to use for..of here, to keep consistency with the rest of the code?

[pi0]

@clarkdo is investigating more but it is probably not going to merged. BTW thanks for PR @maunier ❤️

[pi0]

Hi @maunier Testing repro (https://github.com/maunier/test-vue-ssr.git) with fresh lock-file seems everything is right.

chunks:

../server/client.manifest.json   6.31 KiB          [emitted]              
                    020e051.js  370 bytes    3, 5  [emitted] [immutable]  pages/c2
                    54aff81.js    155 KiB       1  [emitted] [immutable]  commons/app
                    638c457.js   49.5 KiB       0  [emitted] [immutable]  app
                    71a0567.js  478 bytes       2  [emitted] [immutable]  pages/c1
                      LICENSES  389 bytes          [emitted]              
                    cb2fd46.js   2.32 KiB       4  [emitted] [immutable]  runtime
                    eebef40.js  334 bytes       5  [emitted] [immutable]  

client.manifest.json:

  "async": [
    "020e051.js", <-- pages/c2
    "71a0567.js", <-- pages/c1
    "eebef40.js"
  ],

server.manifest.json:

{
  "entry": "server.js",
  "files": {
    "3.js": "3.js",
    "pages/c1.js": "pages/c1.js",
    "pages/c2.js": "pages/c2.js",
    "server.js": "server.js"
  },
  "maps": {
    "3.js": "3.js.map",
    "pages/c1.js": "pages/c1.js.map",
    "pages/c2.js": "pages/c2.js.map",
    "server.js": "server.js.map"
  }
}

Also pages are preloaded when locally testing.

I believe this fixed with 2.14.5 / #8012