Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.14.5 #8041

Merged
merged 15 commits into from Sep 10, 2020
Merged

v2.14.5 #8041

merged 15 commits into from Sep 10, 2020

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Sep 9, 2020

🐛 Bug Fixes

💅 Refactors

🇹 Types

💖 Thanks to

@pi0 pi0 mentioned this pull request Sep 9, 2020
* fix(config): indicator set to true

* fix eslint

* Update options.js

* indicator is not ad-hoc

Co-authored-by: rgermain <germain.remi@protonmail.com>
Co-authored-by: pooya parsa <pyapar@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2020

Codecov Report

Merging #8041 into 2.x will increase coverage by 0.11%.
The diff coverage is 72.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #8041      +/-   ##
==========================================
+ Coverage   68.87%   68.98%   +0.11%     
==========================================
  Files          91       91              
  Lines        3849     3847       -2     
  Branches     1043     1047       +4     
==========================================
+ Hits         2651     2654       +3     
+ Misses        972      969       -3     
+ Partials      226      224       -2     
Flag Coverage Δ
#unittests 68.98% <72.41%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/config/src/config/_common.js 100.00% <ø> (ø)
packages/webpack/src/config/client.js 69.44% <ø> (+6.94%) ⬆️
packages/config/src/load.js 75.28% <16.66%> (-2.63%) ⬇️
packages/webpack/src/config/base.js 64.45% <50.00%> (-0.18%) ⬇️
packages/config/src/options.js 94.56% <71.42%> (-0.70%) ⬇️
packages/config/src/config/build.js 100.00% <100.00%> (ø)
packages/utils/src/task.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c600d5...9989f17. Read the comment docs.

@pi0 pi0 requested a review from a team September 9, 2020 10:35
@pi0 pi0 merged commit 9989f17 into 2.x Sep 10, 2020
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants