Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-app): always import error layout, either internal or custom #8067

Merged
merged 1 commit into from Sep 15, 2020

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Sep 13, 2020

closes #8066

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

The client template needs access to NuxtError and we can follow the pattern of App.js - thanks #8066 (comment) for a helpful diagnosis of the issue.

For reference:

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@codecov-commenter
Copy link

Codecov Report

Merging #8067 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #8067   +/-   ##
=======================================
  Coverage   68.98%   68.98%           
=======================================
  Files          91       91           
  Lines        3847     3847           
  Branches     1047     1047           
=======================================
  Hits         2654     2654           
  Misses        969      969           
  Partials      224      224           
Flag Coverage Δ
#unittests 68.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45b7838...d8eca35. Read the comment docs.

@danielroe danielroe marked this pull request as ready for review September 13, 2020 10:02
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 89a6416 into nuxt:dev Sep 15, 2020
@danielroe danielroe deleted the 8066-nuxterror-not-defined branch September 15, 2020 16:37
@aeadedoyin
Copy link

Hi @pi0 When will this be released? Asper 2.14.6

@pi0 pi0 mentioned this pull request Sep 21, 2020
@Kolobok12309
Copy link
Contributor

@danielroe, Thanks for fix this bug, my fail

@danielroe
Copy link
Member Author

@Kolobok12309 Not at all! It was a good PR and we just didn't spot the issue...

@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NuxtJs: ReferenceError: NuxtError is not defined
7 participants