Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): unregister error event listener #9245

Merged
merged 4 commits into from May 22, 2021
Merged

fix(server): unregister error event listener #9245

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a4bb99
fix(server): remove un-necessary listener
matthieusieben May 6, 2021
f2ce8da
fix(server): remove un-necessary listener
matthieusieben May 15, 2021
3cecf38
test: update listener test
danielroe May 22, 2021
f4a39c6
Merge branch 'dev' into patch-2
danielroe May 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/server/src/listener.js
View file
Open in desktop
Expand Up @@ -75,8 +75,16 @@ export default class Listener {
// Call server.listen
try {
this.server = await new Promise((resolve, reject) => {
this._server.on('error', error => reject(error))
const s = this._server.listen(listenArgs, error => error ? reject(error) : resolve(s))
this._server.on('error', reject)
const s = this._server.listen(listenArgs, (error) => {
s.removeListener(reject)
danielroe marked this conversation as resolved.
Show resolved Hide resolved

if (error) {
reject(error)
} else {
resolve(s)
}
})
})
} catch (error) {
return this.serverErrorHandler(error)
Expand Down