New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: browserslist config file support #9499
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #9499 +/- ##
==========================================
- Coverage 65.15% 65.04% -0.12%
==========================================
Files 94 94
Lines 4107 4114 +7
Branches 1125 1127 +2
==========================================
Hits 2676 2676
- Misses 1153 1158 +5
- Partials 278 280 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think we can hold this pr for now until we support customized targets for SSR
Thanks for PR @ms-fadaei <3. I think for properly solving the issue mentioned in #9337 (comment), we should dynamically generate modernBrowsers based on specified server target. Relying on external config file like |
Thanks for your review @pi0. I will be happy to be part of fixing this issue based on the Nuxt principles, so please let me know what can I do for improving this? |
I run into this while looking at the documentation:
Do I get this correctly that unless we use our own preset config, we're shipping IE9 compatible javascript? Any examples on changing this to target more modern browsers? |
As Nuxt 2 is currently in maintenance-mode until June 30, 2024, we are not aiming to merge any more features and so, regretfully, I am closing this PR. My apologies that we weren't able to include it in v2.17 🙏 |
Add browserslist config file support
Types of changes
Description
Resolves: #9337
After supporting modern browsers config in the Nuxt, there were two things that must be worked on it too:
Checklist: