fix(generator): allow passing builder to getGenerator

[mrazauskas]

Types of changes

• Bug fix (a non-breaking change which fixes an issue)
• New feature (a non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Description

It seems like constructor of Generator class has to receive two arguments (nuxt and builder). Currently getGenerate helper is passing only nuxt to the class. Therefor calling getGenerate(nuxt) throws 'TypeError: Cannot read property 'forGenerate' of undefined...'. It originates from this line, because this.builder is undefined.

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly. (PR: #)
• I have added tests to cover my changes (if not applicable, please state why)
• All new and existing tests are passing.

getGenerate is rather minor and obvious function. I can’t spot it in the test suite. Hope it is acceptable to keep it untested.

[codecov-commenter]

Codecov Report

Merging #9574 (e677bed) into dev (8e725d3) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev    #9574      +/-   ##
==========================================
- Coverage   65.15%   65.14%   -0.02%     
==========================================
  Files          94       94              
  Lines        4107     4108       +1     
  Branches     1126     1126              
==========================================
  Hits         2676     2676              
- Misses       1152     1153       +1     
  Partials      279      279              

Flag	Coverage Δ
unittests	65.14% <0.00%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/generator/src/index.js	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e725d3...e677bed. Read the comment docs.

[pi0]

Thanks for notice and PR @mrazauskas. To avoid cycling dependency between generator and builder, what do you think if:

• Allow passing second builder argument to getGenerator
• Check this.builder here and either skip if or throw an error that it is required when build flag is set.

[mrazauskas]

@pi0 Thanks for the review.

Fixed it. getGenerator now is slim and has similar API as Generator class. That’s better solution, right?

The error message is added as separate PR. See #9663.

[pi0]

Thanks!