Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel): loose option for babel private-property-in-object #9631

Merged
merged 1 commit into from Aug 9, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/babel-preset-app/src/index.js
Expand Up @@ -137,7 +137,8 @@ module.exports = (api, options = {}) => {
// but webpack 4 doesn't support the syntax when target supports and babel transpilation is skipped
// https://github.com/webpack/webpack/issues/9708
'@babel/plugin-proposal-class-properties',
'@babel/plugin-proposal-private-methods'
'@babel/plugin-proposal-private-methods',
'@babel/plugin-proposal-private-property-in-object'
],
shippedProposals,
forceAllTransforms
Expand All @@ -156,7 +157,8 @@ module.exports = (api, options = {}) => {
}],
// class-properties and private-methods need same loose value
[require('@babel/plugin-proposal-class-properties'), { loose: true }],
[require('@babel/plugin-proposal-private-methods'), { loose: true }]
[require('@babel/plugin-proposal-private-methods'), { loose: true }],
[require('@babel/plugin-proposal-private-property-in-object'), { loose: true }]
)

// Transform runtime, but only for helpers
Expand Down