fix(typescript-build): wrong path for dependency #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By using the Nuxt's resolver, it was resolving to whatever version of the package `fork-ts-checker-webpack-plugin` npm or yarn would find. That happened because `@nuxt/core` (the package where the Nuxt's resolver is located) doesn't have `fork-ts-checker-webpack-plugin` as a declared dependency. The version installed by `@nuxt/typescript-build` wouldn't always be used if for instance another version of the dependency is also installed on the project. This fixes #145.
|
Here's a reproduction of the issue #145 where the fix can be tested: https://github.com/IGassmann/nuxt-typescript-issue-145 |
|
@IGassmann Thank for the PR, but I'm afraid it could lead to new issues to not using the Nuxt Resolver, @pi0 would you have a little clue about this change ? |
|
Directly resolving by module makes sense specially if there are known issues of version incompatibility (#145). |
pi0
approved these changes
Jan 17, 2021
Geminii
pushed a commit
to Geminii/typescript
that referenced
this pull request
Jan 20, 2021
This was referenced Mar 8, 2021
Closed
Merged
Open
This was referenced Mar 8, 2021
This was referenced Mar 16, 2021
Closed
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using the Nuxt's resolver, it was resolving to whatever version of the package
fork-ts-checker-webpack-pluginnpm or yarn would find. That happened because@nuxt/core(the package where the Nuxt's resolver is located) doesn't havefork-ts-checker-webpack-pluginas a declared dependency. The version installed by@nuxt/typescript-buildwouldn't always be used if for instance another version of the dependency is also installed on the project.This fixes #145.