Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make typescript a peer dependency #563

Merged
merged 3 commits into from Mar 13, 2023

Conversation

rchl
Copy link
Collaborator

@rchl rchl commented Mar 13, 2023

The changes snowballed a bit but to summarize:

typescript is now a peer dependency for both typescript-build and typescript-runtime.

Using latest typescript triggered a warning for the @typescript-eslint/eslint-plugin as it was too old so updated @nuxtjs/eslint-config-typescript and eslint to latest veersions. This triggered some new eslint warnings so ignored those.

There were also issues related to using latest versions in package.json's as those were picking too new versions that were not compatible. For example vue-property-decorator was on some not-publicly-released version 10 that was triggering errors in test fixtures.

Updated nuxt dependencies to use Nuxt v2 as it would pick Nuxt 3 otherwise. Also had to switch from nuxt-edge to nuxt for now because nuxt/nuxt#19526 is not yet fixed. I can revert that later once things are in order again.

Resolves #512
Resolves #557
Resolves #560

@rchl
Copy link
Collaborator Author

rchl commented Mar 13, 2023

The netlify configuration would need to be updated to help with the CI: https://app.netlify.com/sites/nuxt-typescript/deploys/640f01c3a97ea00008debc41

@cjpearson
Copy link

@rchl is it possible to also support Typescript 5.x as a peer dependency? According to the release notes it's not a disruptive update (5.0 simply comes after 4.9 in their versioning).

@rchl
Copy link
Collaborator Author

rchl commented Mar 20, 2023

Of course. It just needs a little bit of testing to ensure that it doesn't horribly break and I didn't get to it yet since it's so new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants