New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: use vue-component-meta #34
feat!: use vue-component-meta #34
Conversation
Generally LGTM 👍 , but there are some issues we should deal with:
Also, I would love to have @kevinmarrec review, about the schema and possible breaking changes for the editor. |
Should be resolved with vuejs/language-tools#1665 |
@kevinmarrec @farnabaz ; could we state on this PR quickly? I would love to see this happen to iterate on Studio Elements components documentation we're building. |
Everything looks good to me, The only remaining thing is the tests. |
Yep, I'm on it. I've found that the library is not able to load components from |
Hey @stafyniaksacha ; noticed some changes 😄 Is this PR ready for review again? I'm willing to have this ASAP for usage in multiple Nuxt packages, that work is amazing! |
Hey @Tahul ! Yes pretty much ready, waiting on next release of vue-component-meta, so we can get rid of This is why the tests are failing, we can not create one in {
"extends": "./.nuxt/random-xxx/tsconfig.json"
} https://github.com/nuxt/framework/blob/main/packages/test-utils/src/nuxt.ts#L42 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ❤️
This is the first implementation of vue-component-meta to extract
props
/events
/slots
/exposed
using typescript vue language service parser fromvolar
- replaces #23
It can force usage of typescript in javascript components (thanks that vue3 is written in typescript) so detection work, but it needs a
tsconfig.json
in the root of the project. (can be achieved within vue-component-meta)#nuxt-component-meta
virtual module is exposed, so we can use meta inside the project without using a$fetch
(useful to create components documentation)- replaces #32