Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[readme] clarify instructions for running Node on M1 Mac #2675

Merged
merged 1 commit into from
Dec 23, 2021
Merged

[readme] clarify instructions for running Node on M1 Mac #2675

merged 1 commit into from
Dec 23, 2021

Conversation

lukelafountaine
Copy link
Contributor

I got a chance to fix my complaints about the previous M1 docs. There were a lot of unnecessary details included and some misleading comments. I think this simplifies the instructions without removing any important pieces of information.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This reads much more clearly.

Most of the suggestions are using soft wraps instead of hard wraps, or properly referring to node/node.js.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@lukelafountaine
Copy link
Contributor Author

Thanks for the quick response. Updated with your requested changes.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@lukelafountaine
Copy link
Contributor Author

Back to you @ljharb

@lukelafountaine

This comment has been minimized.

@ljharb ljharb merged commit d004c6b into nvm-sh:master Dec 23, 2021
@lukelafountaine lukelafountaine deleted the ldlafountaine/clarify-m1-docs branch December 23, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants