[linux] enabled global menubar on Ubuntu #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposed APIs for global menubar on Ubuntu. This patch also removed global menubar for DevTools window. fixed partially on nwjs/nw.js#2718
rogerwang
force-pushed
the
nw20
branch
2 times, most recently
from
9a12e20
to
413e83b
Compare
rogerwang
force-pushed
the
nw20
branch
2 times, most recently
from
58ab276
to
e62751a
Compare
GnorTech
force-pushed
the
nw20
branch
5 times, most recently
from
997b872
to
d804b23
Compare
GnorTech
pushed a commit
that referenced
this pull request
Jan 29, 2017
The DCHECK doesn't make sense as we might reenable the track during suspend/resume while in the background. BUG=683152 TEST=none Review-Url: https://codereview.chromium.org/2641373002 Cr-Commit-Position: refs/heads/master@{#445128} (cherry picked from commit fd01a87) Review-Url: https://codereview.chromium.org/2651533007 . Cr-Commit-Position: refs/branch-heads/2987@{#58} Cr-Branched-From: ad51088-refs/heads/master@{#444943}
GnorTech
force-pushed
the
nw20
branch
3 times, most recently
from
961e670
to
e9d818b
Compare
rogerwang
force-pushed
the
nw20
branch
8 times, most recently
from
9943f9c
to
0d73593
Compare
rogerwang
force-pushed
the
nw20
branch
3 times, most recently
from
8169d48
to
699e965
Compare
rogerwang
pushed a commit
that referenced
this pull request
Mar 11, 2017
BUG=698816 NOTRY=true NOPRESUBMIT=true TBR=rkaplow Review-Url: https://codereview.chromium.org/2736773002 Cr-Commit-Position: refs/heads/master@{#454966} (cherry picked from commit 15bfa34) Review-Url: https://codereview.chromium.org/2737863003 Cr-Commit-Position: refs/branch-heads/3029@{#58} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech
pushed a commit
that referenced
this pull request
Apr 26, 2017
…chset #1 id:1 of https://codereview.chromium.org/2832473002/ ) Reason for revert: Caused compile failures on Mac and Windows Beta official desktop continuous waterfall. https://bugs.chromium.org/p/chromium/issues/detail?id=713223 Original issue's description: > [Prerender] Restore request priorities when swapped in > > Requests from prerendered contents have a IDLE priority, in order not to slow > down visible pages. > However, when the prerendered contents become visible, the request priorities > were not reset back to their correct values, leading to bad prerendering > performance. > > In this CL, the priority management for prerender requests is moved to the > PrerenderResourceThrottle/PrerendereContents. > The original priorities are stored in the throttle, and restored when the > prerender contents swaps in. > A new public function is added to ResourceDispatcherHost to update a request > priority, and its implementation reuses the existing code that updates the image > priorities. > > The prerender contents keeps a list of all the network resources that were > started while the prerender is hidden. If this proves to be too large, pruning > the list when responses are received should be doable. > > BUG=705955 > > Review-Url: https://codereview.chromium.org/2807163002 > Cr-Commit-Position: refs/heads/master@{#464728} > (cherry picked from commit d3bc614) > > Review-Url: https://codereview.chromium.org/2832473002 . > Cr-Commit-Position: refs/branch-heads/3071@{#48} > Cr-Branched-From: a106f0a-refs/heads/master@{#464641} > Committed: https://chromium.googlesource.com/chromium/src/+/d4b0c9f58ec981f98342cb8438da1a69bb489a06 TBR=droger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=705955 Review-Url: https://codereview.chromium.org/2833553002 Cr-Commit-Position: refs/branch-heads/3071@{#58} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech
pushed a commit
that referenced
this pull request
Aug 5, 2017
This reverts commit 12ac640. Reason for revert: introduces crbug.com/745945 Original change's description: > Add NSAllowsArbitraryLoadsInWebContent Info plist key > > The old NSAllowsArbitraryLoads key is still required for backwards > compatibility when running on old iOS versions. > > EarlGrey test targets need to download insecure images from > browsingtest.appspot.com so add it as an exception domain in > EarlGreyAddition+Info.plist. > > Bug: 622747 > Change-Id: Ide26330939035cd8a876612dc659c48a6e2bd9fc > Reviewed-on: https://chromium-review.googlesource.com/568791 > Reviewed-by: Eugene But <eugenebut@chromium.org> > Commit-Queue: Mike Dougherty <michaeldo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#486376} TBR=eugenebut@chromium.org, michaeldo@chromium.org (cherry picked from commit f0b26ec) Bug: 622747 Change-Id: If3b5cb105118d301fba67ef9b1d4c46859399022 Reviewed-on: https://chromium-review.googlesource.com/580524 Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#488561} Reviewed-on: https://chromium-review.googlesource.com/586968 Cr-Commit-Position: refs/branch-heads/3163@{#58} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech
pushed a commit
that referenced
this pull request
Sep 14, 2017
TBR=dimu@chromium.org Change-Id: Ief163a0110c056916292a0a1f505fecd7cd0cb23 Reviewed-on: https://chromium-review.googlesource.com/654319 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#58} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech
pushed a commit
that referenced
this pull request
Oct 27, 2017
Bug: 775582 Change-Id: I838b3bedf596f9df38668746f1bc6b8235831a6c Reviewed-on: https://chromium-review.googlesource.com/723750 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by: Zijie He <zijiehe@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509542}(cherry picked from commit 4bb8611) Reviewed-on: https://chromium-review.googlesource.com/726753 Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#58} Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang
pushed a commit
that referenced
this pull request
Jan 29, 2018
We count baked-in popular sites to personal sites when deciding whether to refetch the current set of popular sites. This causes popular sites to not refresh if the first fetch failed. With this CL, we treat baked-in popular sites as popular sites which brings back timely refreshes. Bug: 803773 Change-Id: I96c34f02f440d453eb1ae3b422c422c4827b0127 Reviewed-on: https://chromium-review.googlesource.com/878322 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#530857}(cherry picked from commit 764f290) Reviewed-on: https://chromium-review.googlesource.com/883441 Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#58} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech
pushed a commit
that referenced
this pull request
Mar 20, 2018
Bug: 817656 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5faf83e3b1eae38ed977716a1329bfddb3fb271c Reviewed-on: https://chromium-review.googlesource.com/943925 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540313}(cherry picked from commit 444261f) Reviewed-on: https://chromium-review.googlesource.com/953102 Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/branch-heads/3359@{#58} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang
pushed a commit
that referenced
this pull request
Apr 25, 2018
This reverts commit 902d73b. Reason for revert: This causes the ExtensionPopup to dismiss if it brings up a child dialog. See http://crbug.com/832623 Fixing this will require adding support to check for descendant NativeWidget activation, which is too big to merge. Original change's description: > Adjust ExtensionPopup Dismissal Behavior > > Before, dismissing the ExtensionPopup when the anchor window received > focus was an arbitrary decision (http://crbug.com/179786) that allowed > the ExtensionPopup to dismiss at most of the right times. However, if > the some other top-level window received activation, the ExtensionPopup > would not dismiss, unlike a typical menu. > > This change adjusts the ExtensionPopup to always dismiss when it loses > activation as long as devtools is not attached. > > When devtools is detached, activation is placed back on the > ExtensionPopup so that the normal dismissal behavior can continue to > work. Failure to receive activation means the ExtensionPopup will not > dismiss until it receives activation at least once. > > BUG=825867 > > Change-Id: I802af281616c66013c370e892953ad2805533728 > Reviewed-on: https://chromium-review.googlesource.com/984404 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547391} TBR=ellyjones@chromium.org,sky@chromium.org,robliao@chromium.org,rdevlin.cronin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 832623 Change-Id: I69678b789fdbc56501e67b62dd41467e5f2f8cc9 Reviewed-on: https://chromium-review.googlesource.com/1015181 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by: Robert Liao <robliao@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#551444}(cherry picked from commit f58eccd) Reviewed-on: https://chromium-review.googlesource.com/1015723 Cr-Commit-Position: refs/branch-heads/3396@{#58} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang
pushed a commit
that referenced
this pull request
Jun 19, 2018
The call to LoginUIServiceFactory::GetForProfile(profile_) inside ConsentBumpActivator is removed to fix an infinite loop in the LoginUIService. Additional changes: - ConsentBumpActivator is only created when IsUnifiedConsentBumpEnabled() is true - LoginUIService is now created with the browser context - Missing dependencies are added to LoginUIServiceFactory Bug: 847238 Change-Id: I10850be8c3007ed6e68bc89bd64d9c1971d6a22b Reviewed-on: https://chromium-review.googlesource.com/1076067 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562480}(cherry picked from commit b0b6064) Reviewed-on: https://chromium-review.googlesource.com/1079872 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#58} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech
pushed a commit
that referenced
this pull request
Aug 4, 2018
TBR=amineer@chromium.org Change-Id: I88f80c80cd5b6271683f6b99b6dc8d920deb3067 Reviewed-on: https://chromium-review.googlesource.com/1149113 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#58} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang
pushed a commit
that referenced
this pull request
Sep 15, 2018
It is possible that the callback from libassistant comes right after assistant_manager is stopped/reset. Let's guard this case. Bug: 879390 Test: locally build Change-Id: Iea2fe174a02627e6d61406a1319d172470028afd Reviewed-on: https://chromium-review.googlesource.com/1198105 Reviewed-by: Muyuan Li <muyuanli@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#587879}(cherry picked from commit c3a7b6f) Reviewed-on: https://chromium-review.googlesource.com/1207930 Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#58} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang
pushed a commit
that referenced
this pull request
Oct 31, 2018
Clean up code for clear browsing data dialog. Changes: - Remove template elements and add hidden attribute instead - Clean up tests - Remove argument from strings ($1 -> #) Bug: 893696 Change-Id: I0650a0a6fe0bd08884480f6eb4b53e379ba4ebba Reviewed-on: https://chromium-review.googlesource.com/c/1276771 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599643}(cherry picked from commit 59736b1) Reviewed-on: https://chromium-review.googlesource.com/c/1284330 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#58} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang
pushed a commit
that referenced
this pull request
Dec 18, 2018
https://crrev.com/c/1135874 left out checking gamepad events by mistake. This CL fixes it by adding the check against GenericMotionEvent in the content ui event handler. Tested on https://html5gamepad.com with a USB gamepad. TBR=boliu@chromium.org Bug: 906347 Change-Id: I2bd0890f2533e70a772dbb0b005d69bf086d1595 Reviewed-on: https://chromium-review.googlesource.com/c/1356727 Reviewed-by: Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613268}(cherry picked from commit 00ebeca) Reviewed-on: https://chromium-review.googlesource.com/c/1361750 Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#58} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang
pushed a commit
that referenced
this pull request
Feb 10, 2019
TBR=benmason@chromium.org Change-Id: I9f3a918f313e82ed4490368e1afe9b818827319d Reviewed-on: https://chromium-review.googlesource.com/c/1445092 Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#58} Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang
pushed a commit
that referenced
this pull request
Mar 24, 2019
Calculating occlusion information for IntersectionObserver V2 is expensive. To enable IntersectionObserver V2 running in an OOP iframe we must determine, in the process of the parent frame, whether the iframe element is occluded. However, we should only do that calculation if the child frame actually needs it. This CL adds IPC's to request a parent frame to compute occlusion information for an OOP child frame. This way, the cost is only paid when the feature is being used. Cherry-picked from: https://chromium-review.googlesource.com/c/chromium/src/+/1512698 BUG=926539 TBR=chrishtr@chromium.org Change-Id: I4ceb9b32d1e148b46a8a4f9f435b6b882d8f6048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518599 Reviewed-by: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#58} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposed APIs for global menubar on Ubuntu. This patch also removed
global menubar for DevTools window.
fixed partially on nwjs/nw.js#2718