Fix the issue that some applications cannot be rendered #61

xzhan96 · 2017-01-17T06:04:07Z

The issue was brought by the fix of issue #5294. Here can
fix both #5294 and #5528.

BUG=5528

xzhan96 · 2017-01-17T06:05:41Z

the original patch is here #60, @rogerwang please review this new one, thanks.

The issue was brought by the fix of issue #5294. Here can fix both #5294 and #5528. BUG=5528

rogerwang · 2017-01-17T06:11:43Z

extensions/renderer/resources/app_window_custom_bindings.js

@@ -203,7 +203,9 @@ appWindow.registerCustomHook(function(bindingsAPI) {
  apiFunctions.setHandleRequest('getAll', function() {
    var views = runtimeNatives.GetExtensionViews(-1, -1, 'APP_WINDOW');
    return $Array.map(views, function(win) {
-      try_nw(win).nw.Window.get(); //construct the window object for NWJS#5294
+      if (win.nw) {


You are replacing try_nw() with your own logic, which is incorrect ... in some cases 'nw' is defined in privates(win).

Please do not use your own version. Keep the try_nw() function and test 'nw' here.

> Move UpdatePinnedState into AttachSurface since floating close button > participates in the focus chain of the hosting widget now. To create it, > both |surface_| and the hosting widget needs to be present. > > BUG=682868 > > Review-Url: https://codereview.chromium.org/2646143002 > Cr-Commit-Position: refs/heads/master@{#445754} > (cherry picked from commit 57d39ed) Review-Url: https://codereview.chromium.org/2649133009 . Cr-Commit-Position: refs/branch-heads/2987@{#61} Cr-Branched-From: ad51088-refs/heads/master@{#444943}

GSA can apparently use the AwDebug reflection interface at a point where WebView (and hence the crash reporter) hasn't been initialized yet. We should just fail in this case. BUG=698243 Review-Url: https://codereview.chromium.org/2729093004 Cr-Commit-Position: refs/heads/master@{#455426} (cherry picked from commit dec2b22) Review-Url: https://codereview.chromium.org/2735173003 . Cr-Commit-Position: refs/branch-heads/3029@{#61} Cr-Branched-From: 939b32e-refs/heads/master@{#454471}

1. In the system tray, if wifi is disabled, the icon is a white wedge with strikethrough. If wifi is enabled and no network is connected, the icon is an empty wedge without a strikethrough. 2. In the default view (system bubble row) the icon is either a normal, badged icon if connected, an empty wedge if enabled but disconnected, or a full strength wedge with strikethough but with 0.54a if disabled. 3. In the notification, the icon is full strength with or without strikethough, depending on enabled state. BUG=711555 Review-Url: https://codereview.chromium.org/2817223003 Cr-Commit-Position: refs/heads/master@{#464999} (cherry picked from commit 7735ed2) Review-Url: https://codereview.chromium.org/2828853002 . Cr-Commit-Position: refs/branch-heads/3071@{#61} Cr-Branched-From: a106f0a-refs/heads/master@{#464641}

This reverts commit 06adb5e. Reason for revert: Composited border-radius scrolling triggers two regression bugs: 1) crbug.com/740720, it results in high memory usage probably due to mask tiling not saving enough memory; 2) crbug.com/745114, compositor's scroll snapping can sometimes result in blurry text. Original change's description: > cc: Enable composited border-radius scrolling. > > Enable composited border-radius scrolling as mask tiling is implemented. > We'll revert this CL if anything breaks. > > Bug: 567293, 567296 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I70bea4c542e00d244a597d1a36857dd120fc96cd > Reviewed-on: https://chromium-review.googlesource.com/543397 > Commit-Queue: Xianda Sun <sunxd@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#485040} TBR=chrishtr@chromium.org, enne@chromium.org, flackr@chromium.org, schenney@chromium.org, sunxd@chromium.org, trchen@chromium.org (cherry picked from commit 2397e78) Bug: 567293, 567296, 740720, 745114 Change-Id: Ia185a9ce4310aeaff0175f0e9f0a9080dccf22e5 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/585227 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Xianda Sun <sunxd@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#489477} Reviewed-on: https://chromium-review.googlesource.com/586949 Cr-Commit-Position: refs/branch-heads/3163@{#61} Cr-Branched-From: ff259ba-refs/heads/master@{#488528}

TBR=renjieliu@chromium.org (cherry picked from commit b350ff3) Bug: 759410 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibbd2b67ee368c7cb4fb0daa79aace64fc8c1a95c Reviewed-on: https://chromium-review.googlesource.com/640273 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Renjie Liu <renjieliu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#499557} Reviewed-on: https://chromium-review.googlesource.com/654461 Reviewed-by: Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/branch-heads/3202@{#61} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

Bug: 774651 Change-Id: I91c3120212926bb76e95517874f992ceb04d5359 Reviewed-on: https://chromium-review.googlesource.com/722360 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#509393}(cherry picked from commit 02dc512) Reviewed-on: https://chromium-review.googlesource.com/727441 Reviewed-by: Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#61} Cr-Branched-From: adb61db-refs/heads/master@{#508578}

We don't use the keyboard with we're launching Chrome VR for a DLA. Creating it unnecessarily means a startup slow-down of about 500ms - 1s. Bug: 804532 Change-Id: Idc351a7233a07047318845999c4ab5cc13c90dc6 Reviewed-on: https://chromium-review.googlesource.com/879092 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#531101}(cherry picked from commit 371fc8f) Reviewed-on: https://chromium-review.googlesource.com/884101 Reviewed-by: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/branch-heads/3325@{#61} Cr-Branched-From: bc084a8-refs/heads/master@{#530369}

…Host::WasResized If we evict a surface before the previous CompositorFrame activates with it as a fallback, then we will attempt to add an invalid reference and we may end up with missing surfaces in surface aggregator. This CL combats the issue by avoiding evicting frames during resize. We will still only update the primary surface ID if the tab is not hidden, and we will clear the fallback surface ID if the tab is hidden. TBR=fsamuel@chromium.org (cherry picked from commit eb8dd47) Bug: 813157, 672962 TBR: samans@chromium.org Change-Id: I9f35ef24597f0bc88e139b23a2994e8b32abbc70 Reviewed-on: https://chromium-review.googlesource.com/938678 Reviewed-by: Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Original-Original-Commit-Position: refs/heads/master@{#539639} Reviewed-on: https://chromium-review.googlesource.com/943725 Reviewed-by: Fady Samuel <fsamuel@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#540333} Reviewed-on: https://chromium-review.googlesource.com/953126 Cr-Commit-Position: refs/branch-heads/3359@{#61} Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}

…e background iOS doesn't allow app executing OpenGL commands after it goes to the background. Disabling the video stream on the host isn't good enough as the coming video frame will still arrive. This CL fixes the crash by destroying the OpenGL context when the app becomes inactive, and recreates the context when the app becomes active again. Note that even after we fix the crash, the session will still be disconnected, since the app will eventually enter the Suspended state and stop processing network events. See link about an iOS app's lifecycle: https://developer.apple.com/library/content/documentation/iPhone/Conceptual/iPhoneOSProgrammingGuide/TheAppLifeCycle/TheAppLifeCycle.html#//apple_ref/doc/uid/TP40007072-CH2-SW3 Bug: 829449 Change-Id: I507b8e2a856b3e019db99faff188bd5f312c5a51 Reviewed-on: https://chromium-review.googlesource.com/1013244 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by: Jamie Walch <jamiewalch@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#551097}(cherry picked from commit 9e9ae0c) Reviewed-on: https://chromium-review.googlesource.com/1015187 Reviewed-by: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/branch-heads/3396@{#61} Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}

…adMetricsTimerDelay Bug: 847269 Change-Id: Iaaf308b473a2f20db769f72ca421a99fe658cb36 Reviewed-on: https://chromium-review.googlesource.com/1079203 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#563243}(cherry picked from commit 638c712) Reviewed-on: https://chromium-review.googlesource.com/1079736 Reviewed-by: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#61} Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}

…P-R." This reverts commit c2667e3. Reason for revert: Only the first part made it to M69, without the subsequent patches this is just unnecessary overhead. Original change's description: > Reland gpu: Add disk caching for skia generated shaders in OOP-R. > > This reverts commit f9395d7. > > Use the GrContextOptions::PersistentCache API provided by skia to > persist shaders generated internally by skia for OOP raster to disk. > This requires using a special client id to namespace these shaders, > similar to the one used by the InProcessCommandBuffer for viz. > > While the shaders for different sources are stored seperately on disk, > they are finally merged into a single memory cache in the GPU process. In > order to maintain a seperate cache for skia generated shaders, this also > plumbs the client id for a loaded shader to the GPU process. > > TBR=tsepez@chromium.org > > Bug: 854416,840559, 865138 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I65544ccaff96c3154a822dbc2500468fbcac8a0b > Reviewed-on: https://chromium-review.googlesource.com/1142829 > Commit-Queue: Khushal <khushalsagar@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576742} TBR=tsepez@chromium.org,khushalsagar@chromium.org,piman@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 865138 Change-Id: Ia38b186475f802efb81d0764bf0a24350103f868 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1147041 Reviewed-by: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#61} Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}

FrameLoader::StopAllLoaders() has this explicit note: Warning: stopAllLoaders can and will detach the LocalFrame out from under you. All callers need to either protect the LocalFrame or guarantee they won't in any way access the LocalFrame after stopAllLoaders returns. Check frame_'s existence after the call to prevent a NULL dereference. Bug: 879366 Change-Id: I1e537374f59fbad7b069f9de63cfa3b6b2b2b00c Reviewed-on: https://chromium-review.googlesource.com/1198022 Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Kent Tamura <tkent@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#587933}(cherry picked from commit 09b4427) Reviewed-on: https://chromium-review.googlesource.com/1207612 Reviewed-by: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/branch-heads/3538@{#61} Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}

This cl checks the |allowed_status| before starting assistant service. TBR=xiaohuic@chromium.org Bug: b/117371953 Test: manual. Change-Id: I0b638db9d92abd5f54c5f7f41d5f66c25a719f77 Reviewed-on: https://chromium-review.googlesource.com/c/1278345 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#599075}(cherry picked from commit 2a789a6) Reviewed-on: https://chromium-review.googlesource.com/c/1284431 Reviewed-by: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#61} Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}

This change modifies the people section to only show the "Manage other people" row on Chrome OS. On other platforms this option will still be accessible from the Profile Chooser. Bug: 907035 Change-Id: I7c2ab9ee97658e37a11f9d9a6d9ac0736ed2a1d2 Reviewed-on: https://chromium-review.googlesource.com/c/1349336 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#613258}(cherry picked from commit c36d09a) Reviewed-on: https://chromium-review.googlesource.com/c/1362497 Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#61} Cr-Branched-From: d897fb1-refs/heads/master@{#612437}

Currently JsFindinpageManager passes the result of find_in_page.js to base::SysNSStringToUTF8 with "id" type. This CL casts it to NSString to prevent it from crashing the APP when the result is not NSString. Bug: 924441 Change-Id: Ib02e80c09ef8c3af9f877f0c70cf1361fc019dd5 Reviewed-on: https://chromium-review.googlesource.com/c/1433754 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by: Mike Dougherty <michaeldo@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#626028}(cherry picked from commit 831dfd6) Reviewed-on: https://chromium-review.googlesource.com/c/1445038 Reviewed-by: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/branch-heads/3683@{#61} Cr-Branched-From: e510299-refs/heads/master@{#625896}

…on not rotation Previously checkOrientation() would get the new rotation, see if the rotation changed, and if it did call onOrientationChanged() with the new rotation. This is confusing since rotation and orientation mean different things. The only consumer of these onOrientationChanged() events is ToolbarManager#onOrientionChanged() which does two things: 1) ActionModeController#showControlsOnOrientationChange() ActionModeController#showControlsOnOrientationChange() suggests listening to orientation changes is more correct than rotation changes. 2) Update the Duet adaptive toolbar using Configuration#orientation. Listening to orientation changes will fix the adaptive toolbar bugs that are linked. Bug: 938860, 938564, 935348 Change-Id: Icc759d4821b9dd397b0ccc7ea824b143ad474212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512934 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#639642}(cherry picked from commit fa266cacff34c30936e54f7eaf3e2379136c0161) Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519090 Reviewed-by: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/branch-heads/3729@{#61} Cr-Branched-From: d4a8972-refs/heads/master@{#638880}

Fix the issue that some applications cannot be rendered

4b1b58d

The issue was brought by the fix of issue #5294. Here can fix both #5294 and #5528. BUG=5528

rogerwang reviewed Jan 17, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the issue that some applications cannot be rendered #61

Fix the issue that some applications cannot be rendered #61

xzhan96 commented Jan 17, 2017

xzhan96 commented Jan 17, 2017

rogerwang Jan 17, 2017

Fix the issue that some applications cannot be rendered #61

Are you sure you want to change the base?

Fix the issue that some applications cannot be rendered #61

Conversation

xzhan96 commented Jan 17, 2017

xzhan96 commented Jan 17, 2017

rogerwang Jan 17, 2017

Choose a reason for hiding this comment