Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show buttons when entering fullscreen #62

Open
wants to merge 1 commit into
base: nw19
Choose a base branch
from
Open

show buttons when entering fullscreen #62

wants to merge 1 commit into from

Conversation

ghostoy
Copy link
Member

@ghostoy ghostoy commented Jan 20, 2017

and hide them before restoring to normal.

fixed nwjs/nw.js#5651

show buttons when entering fullscreen
1fdc409 
and hide them before restoring to normal.

fixed nwjs/nw.js#5651
GnorTech pushed a commit that referenced this pull request Jan 29, 2017
@kenrb
Give OOPIF FrameViews their own scroll animation timelines and hosts
66ec94e 
OOPIFs need independent scroll animation timelines and hosts, because
they have separate compositors. Ultimately we need to associate a
ScrollingCoordinator which each local frame root, but until that work
is done this CL resolves some known scrolling problems in
--site-per-process mode.

BUG=675695
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2631853002
Cr-Commit-Position: refs/heads/master@{#444947}
(cherry picked from commit 65c7df6)

Review-Url: https://codereview.chromium.org/2654883002 .
Cr-Commit-Position: refs/branch-heads/2987@{#62}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang pushed a commit that referenced this pull request Mar 11, 2017
@miguelgarciaarribas
Transfer the notification icon through XPC as NSData for OSX 10.09
5d850e8 
This is because NSImage only started conforming to NSecureCoding in 10.10

BUG=696759

Review-Url: https://codereview.chromium.org/2728173003
Cr-Commit-Position: refs/heads/master@{#454916}
(cherry picked from commit 52f904d)

Review-Url: https://codereview.chromium.org/2736223002 .
Cr-Commit-Position: refs/branch-heads/3029@{#62}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech pushed a commit that referenced this pull request Apr 26, 2017
Prevent possible crash unregistering VR BroadcastReceiver
31f6c16 
I only saw this crash once, and can't reproduce, but better safe than sorry.

BUG=712823

Review-Url: https://codereview.chromium.org/2830463002
Cr-Commit-Position: refs/heads/master@{#465702}
(cherry picked from commit 3eb6c9f)

Review-Url: https://codereview.chromium.org/2826213002 .
Cr-Commit-Position: refs/branch-heads/3071@{#62}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech pushed a commit that referenced this pull request Aug 5, 2017
Add synthetic field trial for sign-in isolation. (Merge to M61)
d522a7c 
This will allow filtering results for the sign-in process isolation
trial to users that have actually browsed to accounts.google.com.

TBR=alexmos@chromium.org

(cherry picked from commit 95e8906)

Bug: 739418
Change-Id: I31c9b36614cbcf1440c692d29450a851a2e29aa3
Reviewed-on: https://chromium-review.googlesource.com/579629
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Lukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488532}
Reviewed-on: https://chromium-review.googlesource.com/586075
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#62}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech pushed a commit that referenced this pull request Sep 14, 2017
🏡 Remove divider from Notifications Preferences page.
827b654 
TBR=peconn@chromium.org

(cherry picked from commit e8e90c2)

Bug: 762033
Change-Id: I1f9bb01d495ff7b437fbc1e44c53172dffe997a4
Reviewed-on: https://chromium-review.googlesource.com/649531
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499639}
Reviewed-on: https://chromium-review.googlesource.com/654661
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#62}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
ChromeOS: Learn More link on EULA screen should not trigger adjacent …
a969e46 
…checkbox.

When user hits Enter on focused "Learn More" link of the EULA screen, adjacent
checkbox was involuntary triggered. This CL fixed it.

TBR=alemate@chromium.org

(cherry picked from commit ddacd55)

Bug: 771095
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I500ab0c41934c124a6ee1fa03a1ea7f62faf5485
Reviewed-on: https://chromium-review.googlesource.com/721892
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509454}
Reviewed-on: https://chromium-review.googlesource.com/727661
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#62}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
[ios] Increase length of IDS_IOS_FIRSTRUN_AGREE_TO_TERMS to 117em.
5a741d7 
TBR=justincohen@google.com

(cherry picked from commit 96593ad)

Bug: 804621
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If2d7c632d79b35647858a792fcaa721ae09ce710
Reviewed-on: https://chromium-review.googlesource.com/879290
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531131}
Reviewed-on: https://chromium-review.googlesource.com/884003
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#62}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
M66 merge: cros: Add user actions to KSV.
b253b2d 
This cl adds two user actions to Keyboard Shortcut Viewer (KSV):
1. The times user creates a new window of Keyboard Shortcut Viewer.
2. The times user enters search mode in Keyboard Shortcut Viewer.

TBR=afakhry@chromium.org,holte@chromium.org

Bug: 768932
Test: can see the counts in chrome://user-actions.
Change-Id: Id04f20c755def88f6f360d3c66ac1417180d5a94
Reviewed-on: https://chromium-review.googlesource.com/938381
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540300}(cherry picked from commit fdbb173)
Reviewed-on: https://chromium-review.googlesource.com/953029
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#62}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
[EoC] Contextual suggestions opt out
3d3188a 
Add an item in settings to turn on/off contextual suggestions.

TBR=twellington@chromium.org

Bug: 822953
Change-Id: I9533b6afcc21c23ee580e8d7008b6dc3ca1e74d3
Reviewed-on: https://chromium-review.googlesource.com/1006232
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550465}(cherry picked from commit 5ea1b5b)
Reviewed-on: https://chromium-review.googlesource.com/1015725
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#62}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
[M68 Merge] Fixed CSP directive value parsing accepted character range
a318c5d 
TBR=andypaicu@chromium.org

(cherry picked from commit 5b8466d)

Bug: 845961
Change-Id: Ifc9609058cd7cbd268785db46534e3ed09da6ce3
Reviewed-on: https://chromium-review.googlesource.com/1071510
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#561834}
Reviewed-on: https://chromium-review.googlesource.com/1080929
Reviewed-by: Andrew Whalley <awhalley@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#62}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
@chrishtr
Properly invalidate backings of squashed content when it loses its sq…
3e92c6f 
…uashing layer.

Previously, in such situations we failed to mark the layer as needing layer requirements
update, which already has code to issue an invalidation on the new backing of the content
now that it lost squashing.

Bug: 865415

TBR=chrishtr@chromium.org

(cherry picked from commit afd0623)

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I807bf1426e45ce71ed42024512e9c77481f018cc
Reviewed-on: https://chromium-review.googlesource.com/1145896
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577404}
Reviewed-on: https://chromium-review.googlesource.com/1149615
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#62}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
Disable status bar theming in SelectableListToolbar
84d4d12 
Nokia devices crash when trying to set to set the status bar color in
bookmarks, history, and downloads. Disable status bar theming for now.

BUG=880694

Change-Id: I48ae7ec0d7aa5059d70eb5a99b23e84d8263dcd0
Reviewed-on: https://chromium-review.googlesource.com/1207310
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588944}(cherry picked from commit 050fc9e)
Reviewed-on: https://chromium-review.googlesource.com/1208351
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#62}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
Don't clear brand for regular cros sessions.
983503b 
If the brand code persisted in local prefs is empty, reinitialize to correct.

Bug: 846033, 893451
Change-Id: I49cc299374d8530d3a46aee93cb7cb2518ff1dee
Reviewed-on: https://chromium-review.googlesource.com/c/1272447
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599645}(cherry picked from commit 5d80e30)
Reviewed-on: https://chromium-review.googlesource.com/c/1284532
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#62}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
@jdoerrie
[Passwords] Record ManagePasswordsReferrer in UMA Histogram
8dbb6e3 
This change adds a new UMA Histogram that logs the referrer of a navigation to
the manage passwords page. Logging is added in both native and Web UI.

TBR=jdoerrie@chromium.org

(cherry picked from commit 08d6267)

Bug: 904821
Change-Id: I727b0ace112f407121868d79181f523efecab511
Reviewed-on: https://chromium-review.googlesource.com/c/1355604
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613150}
Reviewed-on: https://chromium-review.googlesource.com/c/1361706
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#62}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
Updating XTBs based on .GRDs from branch 3683
4abc0b4 
R=abdulsyed@chromium.org

Change-Id: Ie0b68555565c93350892c66b1b76840af254a497
Reviewed-on: https://chromium-review.googlesource.com/c/1445399
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#62}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
Move tab_list_ui/ code into its own DFM
c0b9245 
BUG=925126

(cherry picked from commit 02d5848947400d769890ab3bfdf8eb66cd731c4e)

Change-Id: I7e0f676f4e9e332945d70bedcbcb6f84665a3c80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1475881
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#639609}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519092
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/branch-heads/3729@{#62}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
Revert "Move tab_list_ui/ code into its own DFM"
af4ab8b 
This reverts commit c0b9245.

Reason for revert: breaks build, bug 941226

Original change's description:
> Move tab_list_ui/ code into its own DFM
> 
> BUG=925126
> 
> (cherry picked from commit 02d5848947400d769890ab3bfdf8eb66cd731c4e)
> 
> Change-Id: I7e0f676f4e9e332945d70bedcbcb6f84665a3c80
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1475881
> Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Theresa <twellington@chromium.org>
> Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#639609}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519092
> Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
> Cr-Commit-Position: refs/branch-heads/3729@{#62}
> Cr-Branched-From: d4a8972-refs/heads/master@{#638880}

TBR=nyquist@chromium.org,isherman@chromium.org,tedchoc@chromium.org,yusufo@chromium.org,twellington@chromium.org,tiborg@chromium.org

Change-Id: I473f8fca0da5bc3276d4ffbed466e8357d0a8bc3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 925126
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519451
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3729@{#71}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ghostoy