Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable flags for ac3 and hevc codecs #65

Open
wants to merge 1 commit into
base: nw19
Choose a base branch
from
Open

enable flags for ac3 and hevc codecs #65

wants to merge 1 commit into from

Conversation

ghostoy
Copy link
Member

@ghostoy ghostoy commented Jan 23, 2017

Flags enable_ac3_eac3_audio_demuxing and enable_hevc_demuxing needed
to be enabled on Chromium side in order to be working with 3rd-party
built ffmpeg libraries for AC3 and HEVC codecs.

fixed nwjs/nw.js#5653

enable flags for ac3 and hevc codecs
bf01f31 
Flags enable_ac3_eac3_audio_demuxing and enable_hevc_demuxing needed
to be enabled on Chromium side in order to be working with 3rd-party
built ffmpeg libraries for AC3 and HEVC codecs.

fixed nwjs/nw.js#5653
GnorTech pushed a commit that referenced this pull request Jan 29, 2017
[Media>UI] Don't show media metadata on lockscreen in Incognito mode
da78931 
Media notification content is marked as private in Incognito mode, so the
content is hidden on lockscreen. For the same reason, we shouldn't show the
artwork image on lockscreen and wearable devices.

BUG=683111

Review-Url: https://codereview.chromium.org/2646793006
Cr-Commit-Position: refs/heads/master@{#445745}
(cherry picked from commit 233f53a)

Review-Url: https://codereview.chromium.org/2657653002 .
Cr-Commit-Position: refs/branch-heads/2987@{#65}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang pushed a commit that referenced this pull request Mar 11, 2017
@ehsan-karamad
Fixing a crash due to calling [RWHVCocoa attributedSubstringForPropos…
e63f1c2 
…edRange] when there is no focused <input>.

RWHVCocoa::attributedSubstringForProposedRange maybe called when there is no
focused <input>. In such cases, renderWidgetHostView_->GetCompositionInfo() returns
nullptr.

BUG=698672

Review-Url: https://codereview.chromium.org/2732143002
Cr-Commit-Position: refs/heads/master@{#455028}
(cherry picked from commit 8c80b23)

Review-Url: https://codereview.chromium.org/2740743003 .
Cr-Commit-Position: refs/branch-heads/3029@{#65}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech pushed a commit that referenced this pull request Apr 26, 2017
Incrementing VERSION to 59.0.3071.14
dd75799 
Cr-Commit-Position: refs/branch-heads/3071@{#65}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech pushed a commit that referenced this pull request Aug 5, 2017
Fix null pointer crash.
6cf4bac 
There might not be a WebContents for a print job.

BUG=748368
TBR=avi@chromium.org

Change-Id: Ic6bc12aa69e7f97b1b7f30894fef2dc57144cbd6
Reviewed-on: https://chromium-review.googlesource.com/585247
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#489396}(cherry picked from commit 6fc1a19)
Reviewed-on: https://chromium-review.googlesource.com/587456
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#65}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech pushed a commit that referenced this pull request Sep 14, 2017
@clelland
Add UseCounter for old allow attribute syntax
3fef18a 
TBR=loonybear@chromium.org

(cherry picked from commit a74fa69)

Bug: 726739, 761009
Change-Id: Ifd0a8e7a020e20b86fe218b607ac69a041b73ce3
Reviewed-on: https://chromium-review.googlesource.com/643759
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499172}
Reviewed-on: https://chromium-review.googlesource.com/655226
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#65}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
Restrict generation context menu item only to non passphrase sync users
73d1627 
BUG=739343, 775509
TBR=melandory@chromium.org

(cherry picked from commit 8c7026b)

Change-Id: I7f9b42cadd63c55c5b59d9787f6a41ff0742a556
Reviewed-on: https://chromium-review.googlesource.com/707436
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509459}
Reviewed-on: https://chromium-review.googlesource.com/727763
Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#65}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
@stevenjb
Fix RTL in network and bluetooth WebUI dialogs
33977f2 
The <html> tag was incorrect for RTL.



TBR=stevenjb@chromium.org

(cherry picked from commit b301a65)

Bug: 796865
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iaebe56c3019f37ee937480af0ac1c847fc291842
Reviewed-on: https://chromium-review.googlesource.com/875157
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531113}
Reviewed-on: https://chromium-review.googlesource.com/883904
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#65}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
M66 merge: Make TabbedPane a11y work properly in CrOS.
efc9001 
This patch makes the a11y work properly in Chrome OS.
1. "search + space" can select a tab.
2. "search + left arrow" navigating tabs can get correct label text.
3. Use up/down arrows to navigate tabs in vertical mode.

TBR=tapted@chromium.org,msw@chromium.org,dmazzoni@chromium.org

Bug: 817709, 768932
Test: tested on device and passed TabbedPaneTest.
Change-Id: I052e60428bf123f3346fae9bbb3255c172e42fd8
Reviewed-on: https://chromium-review.googlesource.com/942693
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540449}(cherry picked from commit a3ca0ea)
Reviewed-on: https://chromium-review.googlesource.com/952872
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#65}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
@csharrison
Don't access ThrottlingURLLoader after calls to |forwarding_client_|
2955468 
The contract for |forwarding_client_| is that the implementation is
free to delete the loader synchronously after calling any of its
methods.

There is one case where we reach into |this| after doing so, which this
CL fixes.

Bug: 833292
Change-Id: Ic5e41649da9e692407f0433a72d2d784f174497b
Reviewed-on: https://chromium-review.googlesource.com/1014024
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550998}(cherry picked from commit 5adb577)
Reviewed-on: https://chromium-review.googlesource.com/1015722
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#65}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
@patrickhulce
DevTools: Audits2 use built-in dialog overlay
65df807 
BUG=845406,847350,846607

Change-Id: Id3ed220dcaf00cfbed5ba7b02e27412eab09b219
Reviewed-on: https://chromium-review.googlesource.com/1076325
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562528}(cherry picked from commit 3fce93a)
Reviewed-on: https://chromium-review.googlesource.com/1081069
Reviewed-by: Patrick Hulce <phulce@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#65}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
@marcq
[iOS] Tune updated new tab animation
4745a26 
A small tweak to the spring damping ratio for the new tab animation, which ensures that the spring effect doesn't show a black hairline on an iPhone X.

Bug: 851872
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1b6769f9d4b124e332efddf2f9602b4665d7aca8
Reviewed-on: https://chromium-review.googlesource.com/1146640
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577156}(cherry picked from commit 946179d)
Reviewed-on: https://chromium-review.googlesource.com/1149800
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#65}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
Changes bool to and instead of or.
ee2046e 
We were moving onto to checking ContextGL if binding failed. This is bad,
because we should not touch ContextGL if we haven't been bound.

Bug: 879438
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7898adf7af963216c388adaa35c5c2c287802fed
Reviewed-on: https://chromium-review.googlesource.com/1200363
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588190}(cherry picked from commit 2008c6b)
Reviewed-on: https://chromium-review.googlesource.com/1208133
Reviewed-by: Abdul Syed <abdulsyed@google.com>
Cr-Commit-Position: refs/branch-heads/3538@{#65}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
[AF] Updates the subtitle for the Autofill Payment Methods settings t…
d1f593a 
…oggle

Bug: 892220
Change-Id: I0aa186011149b4c53697fcfa0a62d3ee60dbe956
Reviewed-on: https://chromium-review.googlesource.com/c/1278885
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599254}(cherry picked from commit 22a175c)
Reviewed-on: https://chromium-review.googlesource.com/c/1284690
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#65}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
@mfalken
M72: service worker: Make LevelDB database outlive its iterator to fi…
ebb70fe 
…x crash.

As explained in the bug by pwnall:
ServiceWorkerDatabase::GetRegistrationsForOrigin() obtains a LevelDB
iterator and calls ServiceWorkerDatabase::ReadResourceRecords() in a
loop. ReadResourceRecords() in turn calls
ServiceWorkerDatabase::HandleReadResult(), which may call
ServiceWorkerDatabase::Disable() if the status is a failure. Disable()
contains a "db_.reset()" which deletes the leveldb::DB instance. So,
ReadResourceRecords() may end up deleting the database before the
iterator used by GetRegistrationsForOrigin() is deleted. The contract
for leveldb::DB::NewIterator() [1] states that the iterator must be
deleted before the DB instance is deleted.

[1] https://cs.chromium.org/chromium/src/third_party/leveldatabase/src/include/leveldb/db.h?l=92&rcl=73d5834eceee8efa9a8ccfec77dc096a9e8ba18a

Bug: 909024
Change-Id: Ifee9aa0f7e1db9168d61b6407a11e249b2001986
Reviewed-on: https://chromium-review.googlesource.com/c/1354730
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#612599}(cherry picked from commit dd5d624)
Reviewed-on: https://chromium-review.googlesource.com/c/1362673
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#65}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
Incrementing VERSION to 73.0.3683.9
e11e491 
TBR=govind@chromium.org

Change-Id: I27d1ac364340909b572c3dcc3777cee9b07abec6
Reviewed-on: https://chromium-review.googlesource.com/c/1446232
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#65}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
@jmuk
Revert "Prevent sending client area for custom-frame widgets"
cd9c25b 
This reverts commit 9f396dd.

Reason for revert: crbug.com/939663

Original change's description:
> Prevent sending client area for custom-frame widgets
> 
> When custom frame is used for a widget, the "client area" shouldn't
> be sent based on the client-area, otherwise the located event on the
> frame will be handled incorrectly.
> 
> With this CL, DesktopWindowTreeHostMus checks remove_standard_frame
> of Widget::InitParams and adopts that behavior, thus dialogs of
> using custom frame and bubbles will not send client area anymore.
> 
> This property is already used in BrowserFrameMash, so
> set_auto_update_client_area method is now gone.
> 
> Bug: 935338
> Test: manually
> Change-Id: I285954a53fea3f9f32d2fc24847cd869e5d5f939
> Reviewed-on: https://chromium-review.googlesource.com/c/1488179
> Auto-Submit: Jun Mukai <mukai@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Commit-Queue: Jun Mukai <mukai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#636248}

TBR=mukai@chromium.org,sky@chromium.org,estade@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 935338
Change-Id: I58f0c9ac298485ff8603e52af3a15f3b51f75452
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1510757
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#638916}(cherry picked from commit 9f2aff2392146f578449a2413c91512d838bc12d)
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519123
Reviewed-by: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3729@{#65}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ghostoy