Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AutoUpdater][OSX] add squirrel auto updater frameworks #66

Open
wants to merge 2 commits into
base: nw20
Choose a base branch
from
Open

[AutoUpdater][OSX] add squirrel auto updater frameworks #66

wants to merge 2 commits into from

Conversation

jtg-gg
Copy link
Member

@jtg-gg jtg-gg commented Feb 23, 2017

No description provided.

@jtg-gg jtg-gg mentioned this pull request Feb 23, 2017
Closed
rogerwang pushed a commit that referenced this pull request Mar 11, 2017
@ehsan-karamad
Hotfix: hasText value is incorrectly set
aab5ba0 
Following the refactoring in CL: 2694543002 the value of hasText is incorrectly
set. To be precise, hasText is always set to the negate of its correct value.

BUG=602427

Review-Url: https://codereview.chromium.org/2735633005
Cr-Commit-Position: refs/heads/master@{#454901}
(cherry picked from commit 6e3e9e5)

Review-Url: https://codereview.chromium.org/2741503002 .
Cr-Commit-Position: refs/branch-heads/3029@{#66}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech pushed a commit that referenced this pull request Apr 26, 2017
@wwwillchen
DevTools: fix date with version, image for What's New
435d20f 
* Use a customizable header string
* Make png smaller

BUG=682879

Review-Url: https://codereview.chromium.org/2813303004
Cr-Commit-Position: refs/heads/master@{#464662}
(cherry picked from commit 629219e)

NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2834473002
Cr-Commit-Position: refs/branch-heads/3071@{#66}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech pushed a commit that referenced this pull request Aug 5, 2017
@dschuyler
[MD settings] change icon-delete to a -gray and -white version
48665a9 
This CL splits the icon-delete svg into icon-delete-gray and
icon-delete-white so that we have two colors to use.

TBR=dschuyler@chromium.org, tommycli@chromium.org

(cherry picked from commit 94d1984)

Bug: 745289
Change-Id: I4d28034520eded8f787ee605bbb0da22f252d698
Reviewed-on: https://chromium-review.googlesource.com/576969
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488540}
Reviewed-on: https://chromium-review.googlesource.com/587421
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#66}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech pushed a commit that referenced this pull request Sep 14, 2017
cros: Fix UMA bug for launcher transitions
7b08318 
Non-fling PEEKING->FULLSCREEN_ALL_APPS was not being
recorded in UMA.

Also, at the request of PMs, I modified the histogram description for
Apps.AppListAppLaunched.

TBR=newcomer@chromium.org

(cherry picked from commit 1c98086)

Bug: 761188
Change-Id: Ia658cac79326678b5e011aca2b1670b6b868e977
Reviewed-on: https://chromium-review.googlesource.com/646762
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499349}
Reviewed-on: https://chromium-review.googlesource.com/655621
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#66}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
@wangxianzhu
Ensure update of scrollbar and caret visual rects on ancestor clip ch…
470d6c4 
…ange

When an ancestor clip changes, we set kSubtreeVisualRectUpdate to update
descendant visual rects which may be affected by the clip change.
Previously we early returned in PaintInvalidator::InvalidatePaint() for
descendants that had only kSubtreeVisualRectUpdate flag set. This caused
other visual rects (of e.g. scrollbars, carets) that are updated during
LayoutObject::InvalidatePaint() not updated.

Now move the early return from PaintInvalidator::InvalidatePaint() into
ObjectPaintInvalidator::ComputePaintInvalidationReason() to ensure the
visual rects are updated.

TBR=wangxianzhu@chromium.org

(cherry picked from commit 6dfcf90)

Bug: 727155
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I28f92281363c693b16121f48d21ab4f808990f14
Reviewed-on: https://chromium-review.googlesource.com/719716
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509648}
Reviewed-on: https://chromium-review.googlesource.com/728300
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#66}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
@stevenjb
Network config: Connect on password enter if configured
b2f42ba 
TBR=stevenjb@chromium.org

(cherry picked from commit 22d9511)

Bug: 804274
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I0e09fab83d79f70545e222c1ca468171264e5e67
Reviewed-on: https://chromium-review.googlesource.com/879230
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531263}
Reviewed-on: https://chromium-review.googlesource.com/883906
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#66}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
@dgozman
[DevTools] Route input events to the correct RenderWidgetHost
58b43c8 
With OOPIFs, we route input events sent to main frame's target
to the correct RenderWidgetHost inside.

We might consider doing the same for non-main frames as well, or
instead prohibit input domain on them.

This does not touch gestures yet, those will follow in next patch.

Bug: 746266

TBR=dgozman@chromium.org

(cherry picked from commit 901b630)

Change-Id: I7ba87c6d227ea24a559ebb7b5ca6a3cf9764d0f0
Reviewed-on: https://chromium-review.googlesource.com/939540
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540419}
Reviewed-on: https://chromium-review.googlesource.com/953163
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#66}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
Incrementing VERSION to 67.0.3396.10
5f50097 
TBR=dimu@chromium.org

Change-Id: I8203121744c0b0856908d53918a3ea447becbb62
Reviewed-on: https://chromium-review.googlesource.com/1015706
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#66}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
Remove enrolled device check for saving login password.
80d8cfc 
Allow managed users logging into their own device to use their
login password for automatically authenticating to networks.

BUG=chromium:386606
TEST=run unit tests, manual test on kevin

Change-Id: I023472e12abaa39a03ea445358f68a7c1afa9391
Reviewed-on: https://chromium-review.googlesource.com/1058598
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: May Lippert <maybelle@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563155}(cherry picked from commit ea3a9c7)
Reviewed-on: https://chromium-review.googlesource.com/1081070
Reviewed-by: May Lippert <maybelle@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#66}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
Update omnibox clear button visibility on focus.
f8d73db 
Monitor omnibox focus notification to update the clear button visibility
on focus.

Bug: 866446, 865019, 865013, 864511
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iecf54d4550e4c6fe3f3988a54602c4d32d417f89
Reviewed-on: https://chromium-review.googlesource.com/1143860
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577161}(cherry picked from commit 06ea7b0)
Reviewed-on: https://chromium-review.googlesource.com/1150100
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#66}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
@chrishtr
Remove over-invalidation of LayoutView on overflow recomputation.
557dccd 
r581008 added a call to SetNeedsCompositingInputsUpdate in LayoutView
whenever overflow needed to be recomputed. It actually only
needs to do that when overflow actually changes. This regresses
any site which causes LayoutView overflow recomputation during
animations.

The call to SetNeedsCompositingInputsUpdate already exists
in LayoutBlock::ComputeOverflow, and correctly only does it
when overflow changes.

An example is tools/perf/page_sets/key_silk_cases/pushState.html,
which was one of the key silk sites that regressed in issue 872172.
In that case, main frame times approximately doubled, because
of the extra work to compute compositing inputs.

crbug.com/872172

TBR=chrishtr@chromium.org

(cherry picked from commit d1042cc)

Change-Id: Iaf4780c0e3ed4d8df67d16d836486df6df0d2f43
Reviewed-on: https://chromium-review.googlesource.com/1200315
Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588205}
Reviewed-on: https://chromium-review.googlesource.com/1208436
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#66}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
Merge Do not disable guest mode when BrowserSignin override ForceBrow…
fba7803 
…esrSignin without a forced value.

Merge the patch into M71.

Bug: 894212
Change-Id: Icd4c7d9f8a79a9b57900366d4677b0e7023b8ca3
Reviewed-on: https://chromium-review.googlesource.com/c/1274196
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599247}(cherry picked from commit df7614e)
Reviewed-on: https://chromium-review.googlesource.com/c/1284729
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#66}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
[Explore sites]: Fix scrolling issue, where clicking on NTP tiles wou…
22a9b38 
…ld sometimes not scroll to the right category on the ESP.

Bug: 910399
Change-Id: Icd9e7cc3a4974d18960458bf633c10df659f968c
Reviewed-on: https://chromium-review.googlesource.com/c/1359512
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Peter Williamson <petewil@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613365}(cherry picked from commit 95f6901)
Reviewed-on: https://chromium-review.googlesource.com/c/1362488
Reviewed-by: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#66}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
@yaoxiachromium @csharrison
Give console warning for deprecation of DownloadInSandboxWithoutUserA…
7befe3c 
…ctivation

Add a method to cover features that was logged from the browser side.

Bug: 539938
Change-Id: I4b6cbdcb8e37afdd5862f15f2f7c877b13d30897
Reviewed-on: https://chromium-review.googlesource.com/c/1437775
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#626402}(cherry picked from commit 9b54c9a)
Reviewed-on: https://chromium-review.googlesource.com/c/1444238
Cr-Commit-Position: refs/branch-heads/3683@{#66}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
@jmuk
Reland "Prevent sending client area for custom-frame widgets"
91619b9 
This is a reland of 9f396dd

Checked the behavior of crbug.com/939663, but actually the main part
of the CL itself isn't wrong, so this CL keeps that as-is.

The reported issue happens because this also fixes the behavior of
accidentally clearing SetClientArea on certain app windows on certain
conditions, which happens to satisfy the behavior of the wallpaper
picker.

Therefore this CL also modifies ChromeNativeAppWindowViewsAuraAsh
to support the case -- sending ClientArea and then clearing it.
Confirmed this does not break crbug.com/939663.

Original change's description:
> Prevent sending client area for custom-frame widgets
>
> When custom frame is used for a widget, the "client area" shouldn't
> be sent based on the client-area, otherwise the located event on the
> frame will be handled incorrectly.
>
> With this CL, DesktopWindowTreeHostMus checks remove_standard_frame
> of Widget::InitParams and adopts that behavior, thus dialogs of
> using custom frame and bubbles will not send client area anymore.
>
> This property is already used in BrowserFrameMash, so
> set_auto_update_client_area method is now gone.
>
> Bug: 935338
> Test: manually
> Change-Id: I285954a53fea3f9f32d2fc24847cd869e5d5f939
> Reviewed-on: https://chromium-review.googlesource.com/c/1488179
> Auto-Submit: Jun Mukai <mukai@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Commit-Queue: Jun Mukai <mukai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#636248}

Bug: 935338, 939663
Change-Id: I85ee6969559d81ec631d02e7dd5f84dedcf830eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1512253
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#639247}(cherry picked from commit 58b4b451de44db57e29b93391faec064c31ebb01)
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1519102
Reviewed-by: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/branch-heads/3729@{#66}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtg-gg @rogerwang @jefry-vcube