Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Linux debug build. #93

Open
wants to merge 1 commit into
base: nw25
Choose a base branch
from

Conversation

hujiajie
Copy link

@hujiajie hujiajie commented Sep 4, 2017

GN reports the following error when trying to build NW.js on Linux with is_debug=true:

ERROR at //headless/BUILD.gn:747:1: Duplicate object file
static_library("headless_shell_lib") {
^-------------------------------------
The target //headless:headless_shell_lib
generates two object files with the same name:
  obj/headless/headless_shell_lib/headless_shell_switches.o

It could be you accidentally have a file listed twice in the
sources. Or, depending on how your toolchain maps sources to
object files, two source files with the same name in different
directories could map to the same object file.

In the latter case, either rename one of the files or move one of
the sources to a separate source_set to avoid them both being in
the same target.

The duplication error is caused by

if (is_debug && is_linux) {
sources += [
"app/headless_shell_switches.cc",
"app/headless_shell_switches.h",
]
}
,
which seems to be unnecessary here.

@hujiajie
Copy link
Author

hujiajie commented Sep 7, 2017

Ping

GnorTech pushed a commit that referenced this pull request Sep 14, 2017
Add an about:flag to force a specific color profile, and add some common
options to this flag. In particular:
  * sRGB, since it's the standard color space
  * Display P3, since it is a common wide gamut profile
  * scRGB Linear, since that will force HDR mode on Windows 10
  * A color spin non-standard gamma space, for testing

Some users who have wide color gamut monitors want the over-saturated
that non-color-correct rendering provided. For these users, on Chrome
61, they must either disable the color correct rendering feature, or
remove their system-installed color profile.

These users who want oversaturated colors on Windows and Linux will have
the option of forcing sRGB as their color profile in about:flags in
Chrome 62 and beyond.

R=hubbe
TBR=ccameron@chromium.org, holte

(cherry picked from commit ceb8727)

Bug: 755747
Change-Id: I80b37432ca42bd0500b443b892bc754727c3f7b7
Reviewed-on: https://chromium-review.googlesource.com/655802
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: ccameron chromium <ccameron@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#500439}
Reviewed-on: https://chromium-review.googlesource.com/657809
Cr-Commit-Position: refs/branch-heads/3202@{#93}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
hujiajie pushed a commit to hujiajie/chromium.src that referenced this pull request Sep 14, 2017
This adds unit test for escaping commas in Polymer strings.
Related to https://codereview.chromium.org/2818053002/

BUG=705850

Review-Url: https://codereview.chromium.org/2814273005
Cr-Commit-Position: refs/heads/master@{#464794}
(cherry picked from commit 8b6a1ef)

Review-Url: https://codereview.chromium.org/2829833005 .
Cr-Commit-Position: refs/branch-heads/3071@{nwjs#93}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GN reports the following error when trying to build NW.js on Linux with
is_debug=true:

  ERROR at //headless/BUILD.gn:747:1: Duplicate object file
  static_library("headless_shell_lib") {
  ^-------------------------------------
  The target //headless:headless_shell_lib
  generates two object files with the same name:
    obj/headless/headless_shell_lib/headless_shell_switches.o

  It could be you accidentally have a file listed twice in the
  sources. Or, depending on how your toolchain maps sources to
  object files, two source files with the same name in different
  directories could map to the same object file.

  In the latter case, either rename one of the files or move one of
  the sources to a separate source_set to avoid them both being in
  the same target.

The duplication error is caused by
https://github.com/nwjs/chromium.src/blob/dcf96012c9c2093e38d49af4dd17c5e680f0ed42/headless/BUILD.gn#L757-L762,
which seems to be unnecessary here.
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
This is the sister test to ChromeContentRendererClientBrowserTest.RewriteYouTubeFlashEmbedObject. Both of them are incompatible with preloading HSTS for youtube.com as written.

TBR=lgarron@chromium.org

(cherry picked from commit bf632cf)

Bug: 771338
Change-Id: I6d3357cbbd3ae978721e0e7c7cafd9410c274db9
Reviewed-on: https://chromium-review.googlesource.com/722448
Reviewed-by: Lucas Garron <lgarron@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Lucas Garron <lgarron@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509734}
Reviewed-on: https://chromium-review.googlesource.com/729715
Cr-Commit-Position: refs/branch-heads/3239@{#93}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
GnorTech pushed a commit that referenced this pull request Dec 16, 2017
changes:
Due to arc window movement targeted at M65, we decided to postpone this
feature to M65. This CL is adding a flag and making it disabled by
default.

TBR=jamescook@chromium.org, stevenjb@chromium.org

(cherry picked from commit b7e9210)

Bug: 773749, 778438
Test: tested on device and played with chrome://flags
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic82018812673a0d079ed8f4604ff9c914fc51865
Reviewed-on: https://chromium-review.googlesource.com/811947
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#522542}
Reviewed-on: https://chromium-review.googlesource.com/816597
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#93}
Cr-Branched-From: 5fdc0fa-refs/heads/master@{#520840}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
TBR=dimu@chromium.org

Change-Id: Ibfb41841fe3947b8ccd6da2f1eeb0403569d917f
Reviewed-on: https://chromium-review.googlesource.com/886965
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#93}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
The fix is for 3 different crashes.
- AccountChooserDialogView::ControllerGone can trigger some accessibility events. The framework needs the title of the dialog. As a result the controller is dereferenced.
- AccountChooserDialogView::ButtonPressed and AccountChooserDialogView::StyledLabelLinkClicked. On Mac those events may be triggered when the dialog already disappeared. Therefore, a NULL-check is required before pinging the controller.

TBR=vasilii@chromium.org

(cherry picked from commit 1fde9e5)

Bug: 792731
Change-Id: Ia177aaa8ace746164ff363ecac94761c3f8f3dc6
Reviewed-on: https://chromium-review.googlesource.com/951002
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#541100}
Reviewed-on: https://chromium-review.googlesource.com/955562
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#93}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
TBR=reveman@chromium.org

(cherry picked from commit 84227cb)

Bug: 833986
Test: No delays when using copy-and-paste in Crostini.
Change-Id: I6722dbd81548b760db8e1ae9a4e3cd1d4c6bf645
Reviewed-on: https://chromium-review.googlesource.com/1015700
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551462}
Reviewed-on: https://chromium-review.googlesource.com/1017601
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3396@{#93}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
Stack#mStackTabs is sometimes null, so we need to do a null pointer check in
NonOverlappingStack#getNonDyingTabCount() to avoid a crash. In particular, the
following sequence of steps currently causes a crash:

- Close all normal tabs and open an incognito tab
- Focus the incognito tab
- Tap the tab switcher button on the toolbar

This CL fixes this crash.

Bug: 831359,846266
Change-Id: I0a64e0134458af772f944d650daf57a0c0650d68
Reviewed-on: https://chromium-review.googlesource.com/1074219
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563254}(cherry picked from commit 399b1c2)
Reviewed-on: https://chromium-review.googlesource.com/1082851
Reviewed-by: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#93}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
Now that we know this pathway is involved in the incorrect setting of
page scale factors for OOPIFs, convert this CHECK to a DCHECK.

TBR=wjmaclean@chromium.org

(cherry picked from commit cb6a710)

Bug: 859428
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4d8805056546cc6ada3525e57d307dbcb27e6f55
Reviewed-on: https://chromium-review.googlesource.com/1146329
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577351}
Reviewed-on: https://chromium-review.googlesource.com/1150842
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#93}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
A previous change misplaced the code to remove all information in addresses. It
is now moved to after GetDetectedValues is computed.

TBR=mathp@chromium.org

(cherry picked from commit 5e05592)

Bug: 878416
Change-Id: I15fd8d8c97d2a051aab9313be98fff5a840fcbd9
Reviewed-on: https://chromium-review.googlesource.com/1207193
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588951}
Reviewed-on: https://chromium-review.googlesource.com/1211503
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#93}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
TBR=benmason@chromium.org

Change-Id: I432f0ee0d7fd69e8af6f66908c1571abed4ec5b7
Reviewed-on: https://chromium-review.googlesource.com/c/1286746
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#93}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
- Use net::EmbeddedTestServer::CERT_EXPIRED SSL Config to trigger errors.

Bug: 910760
Change-Id: I7cae58099003634eb17a6b739b5fd3631ba5bc35
Reviewed-on: https://chromium-review.googlesource.com/c/1359088
Commit-Queue: Misha Efimov <mef@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613686}(cherry picked from commit 6af3825)
Reviewed-on: https://chromium-review.googlesource.com/c/1364232
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#93}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
TBR=mmoss@chromium.org

Change-Id: I8e7977fd7043c8d419382785cd7a0aff6d6accad
Reviewed-on: https://chromium-review.googlesource.com/c/1448531
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#93}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
Bug: 939910
Test: Manual Test
Change-Id: If9a3975e63875f27d4e760e163b147df5dbdad1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1511735
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#640014}(cherry picked from commit c0fc7b7303a3f412705303bb6330b2dc588ab011)
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521467
Reviewed-by: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/branch-heads/3729@{#93}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant