Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating dependencies and more. #784

Open
wants to merge 20 commits into
base: develop
Choose a base branch
from
Open

Conversation

seivan
Copy link

@seivan seivan commented Jun 30, 2022

Updating to latest types, dependencies and other bits.
Also added URI encoded alias.
Should probably do it for the other parts as well.
Checking with trim just incase an empty string is passed as it would validate the condition.

@seivan seivan changed the title Encode URI compatible alias. Updating dependencies and more. Jun 30, 2022
Should probably do it for the other parts as well.
Checking with trim just incase an empty string is passed as it would validate the condition.
…. Reverting to last version before ESM switch
@nwtgck
Copy link
Owner

nwtgck commented Jun 30, 2022

Thank so much for updating. However, I don't accept package update PR for security reasons. The diff is too long to review. I'll try to update instead.

@seivan
Copy link
Author

seivan commented Jun 30, 2022

It's alright I'm actually switching to the CLI with the options defined here to be backwards compatible anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants