New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] CheckModuleBoundaries fails when using 'notDependOnLibsWithTags' configuration #564
Comments
Hey, yeah this plugin's implementation was written before it was added, and the implementation here hasn't been updated. @DerStimmler do you want to submit a PR to fix this? |
@AgentEnder |
@DerStimmler do you still want this issue? I may be able to pick it up soon if not. |
I already worked on it, but struggled with proper testing. |
@AgentEnder I still have problems to test the whole check-module-boundaries feature, because it searches for the I think the general implementation to fix this issue should be done. Could you please have a quick look over the PR? Because I'm not sure wether it's working correctly without the tests. |
You can mock out fast glob in tests, that's probably the best way. I'll lookover the PR, and may push up an example test |
Actually, here's an example if you want to mock that out: https://github.com/nrwl/nx/blob/master/packages/nx/src/config/workspaces.spec.ts |
Thanks for the example. I added some tests for |
🎉 This issue has been resolved in version 1.19.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Describe the bug
Currently it seems that the
notDependOnLibsWithTags
configuration for the enforce-module-boundaries eslint rule doesn't work with nx-dotnet.This feature was added in this PR nrwl/nx#8633.
To Reproduce
Add the
notDependOnLibsWithTags
to the enforce-module-boundaries eslint rules. Add the corresponding tags to theproject.json
of your dotnet project.Expected behavior
The boundaries should be checked like usual with the
onlyDependOnLibsWithTags
configuration. Just inverted.Screenshots
Environment:
The text was updated successfully, but these errors were encountered: