Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add support for notDependOnLibsWithTags module boundaries #592

Merged

Conversation

DerStimmler
Copy link
Contributor

fixes #564

@nx-cloud
Copy link

nx-cloud bot commented Jan 22, 2023

@DerStimmler DerStimmler force-pushed the fix/564_check-module-boundaries branch from 9587b02 to 0ca7825 Compare January 31, 2023 17:20
@DerStimmler
Copy link
Contributor Author

UPDATE: Fixed a small bug and added some tests for onlyDependOnLibsWithTags and notDependOnLibsWithTags.

@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AgentEnder AgentEnder merged commit 483086b into nx-dotnet:master Jan 31, 2023
github-actions bot pushed a commit that referenced this pull request Feb 1, 2023
# [1.19.0](v1.18.1...v1.19.0) (2023-02-01)

### Bug Fixes

* **core:** install not ran after generating a webapi with useNxPluginOpenAPI ([#601](#601)) ([15e4db5](15e4db5))
* **core:** make eslint optional dependency ([#608](#608)) ([3705469](3705469))

### Features

* **core:** add support for notDependOnLibsWithTags module boundaries ([#592](#592)) ([483086b](483086b))

Feb 1, 2023, 3:40 AM
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

🎉 This PR is included in version 1.19.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CheckModuleBoundaries fails when using 'notDependOnLibsWithTags' configuration
2 participants