Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed blocking for coconut in the final epoch state #4598

Merged
merged 1 commit into from
May 21, 2024
Merged

removed blocking for coconut in the final epoch state #4598

merged 1 commit into from
May 21, 2024

Conversation

jstuczyn
Copy link
Contributor

@jstuczyn jstuczyn commented May 17, 2024 •
edited by tommyv1987

Description

Removed blocking for coconut in the final epoch state

@vercel Vercel
Copy link

vercel bot commented May 17, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
nym-explorer ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 10:04am
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview May 17, 2024 10:04am

@jstuczyn jstuczyn force-pushed the feature/remove-coconut-wait-buffer branch from 0be3c5a to 2f5a00d Compare May 17, 2024 10:04
@jstuczyn jstuczyn merged commit 9f20c8e into develop May 21, 2024
23 checks passed
@jstuczyn jstuczyn deleted the feature/remove-coconut-wait-buffer branch May 21, 2024 09:19
@benedettadavico benedettadavico added this to the Ragusa milestone May 21, 2024
@tommyv1987
Copy link
Contributor

tommyv1987 commented May 21, 2024 •
edited

Testing Completion Date: 2024-05-21

Testing Steps Performed:

  1. Built the project to ensure no compilation errors.
  2. Ran tests to verify the functionality of the issue_credential function.
  3. Executed integration tests to check the behaviour during an epoch transition.

Validation:

  • Test Passed
  • Issues Found (Please specify below)

Notes (if any):

  • The safety buffer for halting deposits during an epoch transition works as expected.
  • The function exits appropriately when the safety buffer condition is met.
  • No issues were encountered during the testing process.

Attachments (if applicable):

  • No issues found, so no additional attachments are necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benedettadavico benedettadavico benedettadavico approved these changes

Assignees

@benedettadavico benedettadavico

Labels
None yet
Projects
None yet
Milestone
Ragusa
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jstuczyn @tommyv1987 @benedettadavico