Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nym-api: make report/avg_uptime endpoints ignore blacklist #4599

Merged
merged 1 commit into from
May 21, 2024

Conversation

jstuczyn
Copy link
Contributor

@jstuczyn jstuczyn commented May 17, 2024

Description

this PR makes one particular change: when querying for node specific data, it's no longer going to go through the entire list of all cached (and filtered nodes) to find it; instead it will attempt to retrieve a single unfiltered entry

Checklist:

  • added a changelog entry to CHANGELOG.md

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
nym-explorer ⬜️ Ignored (Inspect) May 17, 2024 10:01am
nym-next-explorer ⬜️ Ignored (Inspect) May 17, 2024 10:01am

@tommyv1987 tommyv1987 added this to the Ragusa milestone May 21, 2024
@tommyv1987
Copy link
Contributor

Testing Completion Date: 2024-05-21

Testing Steps Performed:

  1. Tests:
    • built the project and deployed it in a test environment.
    • manually tested API endpoints for mixnode and gateway data.
    • verified that the endpoints return the expected data and handle blacklists correctly.
    • test standard uptime routes:
curl -X 'GET' 'https://qa-nym-api.qa.nymte.ch/api/v1/status/gateway/3ZmKvV3Fax9A8txxQ3GKh9fUeyTAk68rK4Yn4m3Vdvp9/avg_uptime' -H 'accept: application/json'
curl -X 'GET' 'https://sandbox-nym-api1.nymtech.net/api/v1/status/mixnode/35/avg_uptime' -H 'accept: application/json'

Validation:

  • Test Passed
  • Issues Found (Please specify below)

Notes (if any):

  • all tests passed successfully.
  • API performance improved due to the efficient HashMap lookups.
  • no issues were encountered during testing.
  • data in mainnet will differ from test nets due to the increased amount of gateways and mixnodes in that environment

Attachments (if applicable):

  • no issues found, so no additional attachments are necessary.

@tommyv1987 tommyv1987 merged commit ce2449f into develop May 21, 2024
14 checks passed
@tommyv1987 tommyv1987 deleted the feature/expose-all-api-reports branch May 21, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants