Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #68 from jstarpl/fix/workerThreadsErrors
fix: forward errors that happened in side-effects from threads to consumers
- Loading branch information
Showing
15 changed files
with
375 additions
and
76 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,155 @@ | ||
| import { | ||
| threadedClass, | ||
| ThreadedClassManager | ||
| } from '../index' | ||
| import { TestClassErrors } from '../../test-lib/testClassErrors' | ||
| import { RegisterExitHandlers } from '../parent-process/manager' | ||
| import { tmpdir } from 'os' | ||
| import { join } from 'path' | ||
| import { promises } from 'fs' | ||
| const TESTCLASS_PATH = '../../test-lib/testClassErrors.js' | ||
|
|
||
| describe('threadedclass', () => { | ||
| const TMP_STATE_FILE = join(tmpdir(), 'test_state') | ||
|
|
||
| async function clearTestTempState (): Promise<void> { | ||
| try { | ||
| await promises.unlink(TMP_STATE_FILE) | ||
| } catch { | ||
| // don't do anything | ||
| } | ||
| } | ||
|
|
||
| beforeAll(async () => { | ||
|
|
||
| ThreadedClassManager.handleExit = RegisterExitHandlers.NO | ||
| ThreadedClassManager.debug = false | ||
|
|
||
| await clearTestTempState() | ||
| }) | ||
|
|
||
| afterAll(async () => { | ||
| await clearTestTempState() | ||
| }) | ||
|
|
||
| test('restart after error', async () => { | ||
| const RESTART_TIME = 100 | ||
|
|
||
| let threaded = await threadedClass<TestClassErrors, typeof TestClassErrors>(TESTCLASS_PATH, 'TestClassErrors', [], { | ||
| autoRestart: true, | ||
| threadUsage: 1 | ||
| }) | ||
| let onClosed = jest.fn(() => { | ||
| // oh dear, the process was closed | ||
| }) | ||
| const onError = jest.fn(() => { | ||
| // we had a global uncaught error | ||
| }) | ||
| const onRestarted = jest.fn(() => { | ||
| // the thread was restarted | ||
| }) | ||
|
|
||
| ThreadedClassManager.onEvent(threaded, 'thread_closed', onClosed) | ||
| ThreadedClassManager.onEvent(threaded, 'error', onError) | ||
| ThreadedClassManager.onEvent(threaded, 'restarted', onRestarted) | ||
|
|
||
| expect(await threaded.doAsyncError()).toBeTruthy() | ||
| await sleep(10) | ||
| expect(onClosed).toHaveBeenCalledTimes(1) | ||
| if (process.version.startsWith('v10.')) { | ||
| // In Node 10, errors in setTimeout are only logged | ||
| expect(onError).toHaveBeenCalledTimes(0) | ||
| } else { | ||
| expect(onError).toHaveBeenCalledTimes(1) | ||
| } | ||
|
|
||
| await sleep(RESTART_TIME) | ||
|
|
||
| let counter = 0 | ||
| await threaded.on('test', () => { | ||
| counter = 1 | ||
| }) | ||
| expect(threaded.emitEvent('test')) | ||
| await sleep(10) | ||
| expect(counter).toEqual(1) | ||
| expect(onRestarted).toHaveBeenCalledTimes(1) | ||
|
|
||
| expect(await threaded.doAsyncError()).toBeTruthy() | ||
| await sleep(10) | ||
| expect(onClosed).toHaveBeenCalledTimes(2) | ||
|
|
||
| await sleep(RESTART_TIME) | ||
|
|
||
| expect(threaded.emitEvent('test')) | ||
| await sleep(10) | ||
| expect(counter).toEqual(1) // the underlying class has been reset, so we shouldn't expect to have the event handler registered | ||
|
|
||
| await ThreadedClassManager.destroyAll() | ||
| expect(ThreadedClassManager.getThreadCount()).toEqual(0) | ||
|
|
||
| expect(onRestarted).toHaveBeenCalledTimes(2) | ||
| expect(onClosed).toHaveBeenCalledTimes(3) | ||
| expect(onRestarted).toHaveBeenCalledTimes(2) | ||
| if (process.version.startsWith('v10.')) { | ||
| // In Node 10, errors in setTimeout are only logged | ||
| expect(onError).toHaveBeenCalledTimes(0) | ||
| } else { | ||
| expect(onError).toHaveBeenCalledTimes(2) | ||
| } | ||
| }) | ||
|
|
||
| test('emit error if constructor crashes on subsequent restart', async () => { | ||
| const RESTART_TIME = 100 | ||
|
|
||
| let threaded = await threadedClass<TestClassErrors, typeof TestClassErrors>(TESTCLASS_PATH, 'TestClassErrors', [1, TMP_STATE_FILE], { | ||
| autoRestart: true, | ||
| threadUsage: 1, | ||
| restartTimeout: 100 | ||
| }) | ||
| let onClosed = jest.fn(() => { | ||
| // oh dear, the process was closed | ||
| }) | ||
| const onError = jest.fn((_e) => { | ||
| // we had a global uncaught error | ||
| }) | ||
| const onRestarted = jest.fn(() => { | ||
| // the thread was restarted | ||
| }) | ||
|
|
||
| ThreadedClassManager.onEvent(threaded, 'thread_closed', onClosed) | ||
| ThreadedClassManager.onEvent(threaded, 'error', onError) | ||
| ThreadedClassManager.onEvent(threaded, 'restarted', onRestarted) | ||
|
|
||
| expect(await threaded.returnValue('test')).toBe('test') | ||
| await sleep(10) | ||
| expect(onClosed).toHaveBeenCalledTimes(0) | ||
| expect(onError).toHaveBeenCalledTimes(0) | ||
|
|
||
| await sleep(RESTART_TIME) | ||
|
|
||
| expect(await threaded.doAsyncError()).toBeDefined() | ||
|
|
||
| await sleep(100) | ||
|
|
||
| expect(onClosed).toHaveBeenCalledTimes(2) | ||
| if (process.version.startsWith('v10.')) { | ||
| // In Node 10, errors in setTimeout are only logged | ||
| expect(onError).toHaveBeenCalledTimes(1) | ||
| } else { | ||
| expect(onError).toHaveBeenCalledTimes(2) | ||
| } | ||
| expect(onError.mock.calls[onError.mock.calls.length - 1][0]).toMatch(/Error in constructor/) | ||
|
|
||
| await sleep(500) | ||
|
|
||
| try { | ||
| await ThreadedClassManager.destroy(threaded) | ||
| } catch (e) { | ||
| // console.log('Could not close class proxy') | ||
| } | ||
| }) | ||
| }) | ||
|
|
||
| function sleep (ms: number): Promise<void> { | ||
| return new Promise(resolve => setTimeout(resolve, ms)) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.