Fix: remove legacy electron worker thread loader

[hrueger]

fixes #74

like @Julusian I think it's ok to remove support for electron < 17.3 as electron 17 had its EOL in August 2022.

[codecov-commenter]

Codecov Report

Merging #75 (1e063a1) into master (0d4dfce) will decrease coverage by 0.19%.
The diff coverage is 57.14%.

❗ Current head 1e063a1 differs from pull request most recent head c3fedd5. Consider uploading reports for the commit c3fedd5 to get more accurate results

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   83.83%   83.64%   -0.20%     
==========================================
  Files          12       12              
  Lines        1126     1131       +5     
  Branches      270      271       +1     
==========================================
+ Hits          944      946       +2     
- Misses        180      183       +3     
  Partials        2        2              

Impacted Files	Coverage Δ
src/parent-process/workerPlatform/workerThreads.ts	75.55% <57.14%> (-4.45%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[hrueger]

I just noticed that the README section I deleted also included info about using a custom loader in general. Should I re-add that?

[Julusian]

I've been thinking on this, and I think that short-term it would be best to not completely drop support for older electron.
While those versions of electron are EOL, I feel that doing so would require this library to do a major version bump, otherwise users who are using an older version (eg companion) will get a surprise when the update gets pulled in and it stops working for them.
And if this library does do a major version bump, then consumers (eg atem-connection) also should be doing a major version bump so that it doesnt get pulled in and break uses of it.

So while it is a messier fix, I think that for now doing some version checks is a better strategy to minimise pain for consumers of this library. That will allow for this to be done as a patch version, and be easily pulled in by dependencies without them doing any extra work

[hrueger]

Makes sense, I'll implement that.

[nytamin]

Thank you for taking the time to both troubleshoot and fix this issue!

I took the liberty to copy your minimal reproduction repo and add it as a manual test to this repo (in PR #77 ), so hopefully we'll discover this type of issue early next time!

I'll get this merged and released asap

[hrueger]

Great news, thanks a lot 👍

[nytamin]

Fix released in version 1.2.1