Don't prefix enums unless namespace-enums is true #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The -namespace-enums command-line flag doesn't seem to be working because of this. (I've tried it true/false with no effect either way - it always adds prefixes. I can provide a repro if needed.)
|
Hi maintainers! I see the failing tests here and am hoping for a bit of guidance - should I attempt to fix the tests, or change the default value of -namespace-enums to true (since it seems that it's always on right now)? |
|
Hi @jprobinson, not sure if you're still working on this codebase but was hoping for a bit of advice on the above. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The -namespace-enums command-line flag doesn't seem to be working because of this. (I've tried it true/false with no effect either way - it always adds prefixes. I can provide a repro if needed.)