ci: add pylint job #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aesteve-rh
force-pushed
the
aesteve/ci-pylint
branch
11 times, most recently
from
2b6fee1
to
1410a3c
Compare
|
Passing pipeline: https://github.com/aesteve-rh/ovirt-stress/runs/8092118699 |
aesteve-rh
force-pushed
the
aesteve/ci-pylint
branch
from
1410a3c
to
b1cff55
Compare
nirs
requested changes
Sep 4, 2022
There was a problem hiding this comment.
I did not review all changes, but they do not look helpful for this code. In general the code is worse with these changes, and it is full of cryptic pylint codes.
Most likely the pylint configuration enable rules that should not be enabled. Start with minimal configuration that pass with the current code, and add rules one by one as needed.
aesteve-rh
force-pushed
the
aesteve/ci-pylint
branch
from
b1cff55
to
9f7cd64
Compare
|
I have reviewed the rules and the ones that are enabled are pretty basic, and helped to fix a few bugs in the code. I'll ready this PR up. |
aesteve-rh
force-pushed
the
aesteve/ci-pylint
branch
from
9f7cd64
to
ac638b1
Compare
aesteve-rh
force-pushed
the
aesteve/ci-pylint
branch
3 times, most recently
from
d822a54
to
ad98e6e
Compare
nirs
approved these changes
Nov 28, 2022
Add pylint.yml to have basic linting CI job. The workflow is the official GH pylint template with some extra installs to satisfy dependencies. This requires installing dependiencies on each run, but is a good starting point for the new workflow. Use an autogenerated pylintrc configuration that passes with current code. Signed-off-by: Albert Esteve <aesteve@redhat.com>
Signed-off-by: Albert Esteve <aesteve@redhat.com>
Signed-off-by: Albert Esteve <aesteve@redhat.com>
Signed-off-by: Albert Esteve <aesteve@redhat.com>
Signed-off-by: Albert Esteve <aesteve@redhat.com>
Signed-off-by: Albert Esteve <aesteve@redhat.com>
Signed-off-by: Albert Esteve <aesteve@redhat.com>
aesteve-rh
force-pushed
the
aesteve/ci-pylint
branch
from
ad98e6e
to
63e2ee3
Compare
|
https://github.com/aesteve-rh/ovirt-stress/actions/runs/3566260851 The action passed on my fork :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pylint.yml to have basic linting CI job.
Signed-off-by: Albert Esteve aesteve@redhat.com