Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eslint-plugin-import from 2.24.2 to 2.25.1 #259

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 12, 2021

Bumps eslint-plugin-import from 2.24.2 to 2.25.1.

Release notes

Sourced from eslint-plugin-import's releases.

v2.25.1

Full Changelog: import-js/eslint-plugin-import@v2.25.0...v2.25.1

v2.25.0

What's Changed

New Contributors

Full Changelog: import-js/eslint-plugin-import@v2.24.2...v2.25.0

Changelog

Sourced from eslint-plugin-import's changelog.

[2.25.1] - 2021-10-11

Fixed

  • [Deps] update eslint-module-utils

[2.25.0] - 2021-10-11

Added

Fixed

  • [no-unresolved]: ignore type-only imports (#2220, thanks [@​jablko])
  • [order]: fix sorting imports inside TypeScript module declarations (#2226, thanks [@​remcohaszing])
  • [default], ExportMap: Resolve extended TypeScript configuration files (#2240, thanks [@​mrmckeb])

Changed

  • [Refactor] switch to an internal replacement for pkg-up and read-pkg-up (#2047, thanks [@​mgwalker])
  • [patch] TypeScript config: remove .d.ts from [import/parsers setting] and [import/extensions setting] (#2220, thanks [@​jablko])
  • [Refactor] [no-unresolved], [no-extraneous-dependencies]: moduleVisitor usage (#2233, thanks [@​jablko])
Commits
  • 9cc1654 Bump to v2.25.1
  • 6bdab31 [Deps] update eslint-module-utils
  • b0131d2 Bump to v2.25.0
  • 7463de2 utils: v2.7.0
  • 900ac9a [resolvers/webpack] [deps] update is-core-module
  • c117be5 [Dev Deps] update array.prototype.flatmap, glob; remove `babel-preset-es2...
  • 0e857b6 [Deps] update array-includes, array.prototype.flat, is-core-module, `is...
  • 62e2d88 [New] Support eslint v8
  • 9a744f7 [Fix] default, ExportMap: Resolve extended TypeScript configuration files
  • dd81424 [Refactor] no-unresolved, no-extraneous-dependencies: moduleVisitor usage
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once it's up-to-date and CI passes on it, as requested by @pro-wh.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the c:deps Category: external dependencies label Oct 12, 2021
Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release notes sound fine

fortunate that we haven't been waiting for dynamic and glob imports

@dependabot merge

@pro-wh
Copy link
Contributor

pro-wh commented Oct 12, 2021

oh this seems to be incompatible with the eslint preset we use. or something

 ERROR  Failed to compile with 1 errors7:06:35 AM

 error  in ./vue_example/main.js

Module build failed (from ./node_modules/thread-loader/dist/cjs.js):
Thread Loader (Worker 0)
Failed to load plugin 'import' declared in '.eslintrc.json » eslint-config-airbnb-base » /home/runner/work/ledger-js/ledger-js/node_modules/eslint-config-airbnb-base/rules/imports.js': Cannot find module 'eslint-module-utils/visit'
Require stack:
- /home/runner/work/ledger-js/ledger-js/node_modules/eslint-plugin-import/lib/ExportMap.js
- /home/runner/work/ledger-js/ledger-js/node_modules/eslint-plugin-import/lib/rules/named.js
 ERROR  Build failed with errors.
- /home/runner/work/ledger-js/ledger-js/node_modules/eslint-plugin-import/lib/index.js
- /home/runner/work/ledger-js/ledger-js/node_modules/@eslint/eslintrc/lib/config-array-factory.js
- /home/runner/work/ledger-js/ledger-js/node_modules/@eslint/eslintrc/lib/index.js
- /home/runner/work/ledger-js/ledger-js/node_modules/eslint/lib/cli-engine/cli-engine.js
- /home/runner/work/ledger-js/ledger-js/node_modules/eslint/lib/cli-engine/index.js
- /home/runner/work/ledger-js/ledger-js/node_modules/eslint/lib/api.js
- /home/runner/work/ledger-js/ledger-js/node_modules/eslint-loader/index.js
- /home/runner/work/ledger-js/ledger-js/node_modules/loader-runner/lib/loadLoader.js
- /home/runner/work/ledger-js/ledger-js/node_modules/loader-runner/lib/LoaderRunner.js
- /home/runner/work/ledger-js/ledger-js/node_modules/thread-loader/dist/worker.js
    at PoolWorker.fromErrorObj (/home/runner/work/ledger-js/ledger-js/node_modules/thread-loader/dist/WorkerPool.js:262:12)
    at /home/runner/work/ledger-js/ledger-js/node_modules/thread-loader/dist/WorkerPool.js:204:29
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:815:15)
    at Function.Module._load (internal/modules/cjs/loader.js:667:27)
    at Module.require (internal/modules/cjs/loader.js:887:19)
    at require (internal/modules/cjs/helpers.js:74:18)
    at Object.<anonymous> (/home/runner/work/ledger-js/ledger-js/node_modules/eslint-plugin-import/lib/ExportMap.js:733:444)
    at Module._compile (internal/modules/cjs/loader.js:999:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
    at Module.load (internal/modules/cjs/loader.js:863:32)
    at Function.Module._load (internal/modules/cjs/loader.js:708:14)
    at Module.require (internal/modules/cjs/loader.js:887:19)

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/eslint-plugin-import-2.25.1 branch from 250da8d to a4b4409 Compare October 12, 2021 22:17
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 12, 2021

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

Bumps [eslint-plugin-import](https://github.com/import-js/eslint-plugin-import) from 2.24.2 to 2.25.1.
- [Release notes](https://github.com/import-js/eslint-plugin-import/releases)
- [Changelog](https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md)
- [Commits](import-js/eslint-plugin-import@v2.24.2...v2.25.1)

---
updated-dependencies:
- dependency-name: eslint-plugin-import
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/eslint-plugin-import-2.25.1 branch from a4b4409 to fb5ec89 Compare October 12, 2021 22:28
@pro-wh
Copy link
Contributor

pro-wh commented Oct 12, 2021

or no, this eslint-plugin-import package needs to be in sync with its friend eslint-module-utils

side question: why are we on specifically version 14 of the airbnb base thing?

@pro-wh
Copy link
Contributor

pro-wh commented Oct 12, 2021

import-js/eslint-plugin-import#2255 tracked here. see you next release

@pro-wh pro-wh closed this Oct 12, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 12, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/eslint-plugin-import-2.25.1 branch October 12, 2021 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:deps Category: external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant