Hide account derivation path in import dialog #1917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lukaw3d
commented
May 4, 2024
lukaw3d
commented
| Before | After |
|---|---|
 |
 |
 |
 |
Deployed to Cloudflare Pages
|
lubej
approved these changes
May 4, 2024
| @@ -17,10 +17,6 @@ export const ImportableAccount = ({ | |||
| displayBalance={true} | |||
| displayCheckbox={true} | |||
| displayAccountNumber={true} | |||
| displayDerivation={{ | |||
There was a problem hiding this comment.
I kinda liked the derivation path. Any reason it is going away?
There was a problem hiding this comment.
With Don we were trying to improve illegible "BLE Ledger":
- we tried and liked an icon https://icons.grommet.io/?s=bluetooth instead
- we didn't find the best icon for usb https://icones.js.org/collection/all?s=usb but could also just keep "USB"
- balance position depends on the account type, and longer derivation paths needed fixing
We also don't show it inside account selector, where it would actually add more information:
Removing it in import and keeping it in account manage and expanding BLE to Bluetooth was simplest. But I like derivation too :/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.