Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-hosted fonts #772

Merged
merged 1 commit into from Mar 30, 2022
Merged

Self-hosted fonts #772

merged 1 commit into from Mar 30, 2022

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Mar 24, 2022

Closes #526

  • Tested using Chrome/FF/Safari
  • I've removed Inter web font completely, because we are not using it in our app. This also deprecates usage of fontfaceobserver dependency in the app

@buberdds
Copy link
Contributor Author

buberdds commented Mar 24, 2022

I've forgot about CSP rules

@buberdds buberdds force-pushed the googleFonts branch 3 times, most recently from fa17dd6 to 48ffbd3 Compare March 24, 2022 15:51
@buberdds buberdds requested review from lukaw3d and matevz March 24, 2022 16:02
@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #772 (c49d2af) into master (9d1bd73) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head c49d2af differs from pull request most recent head 316d9b7. Consider uploading reports for the commit 316d9b7 to get more accurate results

@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
- Coverage   88.26%   88.24%   -0.03%     
==========================================
  Files         100      100              
  Lines        1696     1693       -3     
  Branches      338      338              
==========================================
- Hits         1497     1494       -3     
  Misses        199      199              
Flag Coverage Δ
cypress 57.89% <ø> (-0.08%) ⬇️
jest 74.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/app/components/Sidebar/index.tsx 84.61% <ø> (ø)
src/index.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d1bd73...316d9b7. Read the comment docs.

@buberdds
Copy link
Contributor Author

buberdds commented Mar 28, 2022

e2e test is failing due to missing governance.SubmitProposal. That is covered in #776

package.json Outdated Show resolved Hide resolved
@buberdds buberdds force-pushed the googleFonts branch 4 times, most recently from be82a86 to 0209be9 Compare March 29, 2022 16:45
@buberdds buberdds requested a review from lukaw3d March 29, 2022 17:18
Copy link
Member

@lukaw3d lukaw3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep yep

megalinter 🤷

@buberdds buberdds merged commit a29bd1a into oasisprotocol:master Mar 30, 2022
@buberdds buberdds deleted the googleFonts branch March 31, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self-host Google fonts
2 participants