Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable babel updates #32

Merged
merged 2 commits into from Jul 5, 2022
Merged

Enable babel updates #32

merged 2 commits into from Jul 5, 2022

Conversation

krampstudio
Copy link
Contributor

@krampstudio krampstudio commented Jul 4, 2022

  • Update babel & co
  • Prevent an issue by disabling dead code elimination during the minification, so we can rely on any version of Babel safely. We will be able to remove it when the bug will be fixed.

How to test

Along with oat-sa/tao-core#3569 try to bundle tao-core and use the auhtoring.

Copy link

@Silvia-loza Silvia-loza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working as expected now, thank you for the quick fix! 🎬

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • Pull request's target is not master
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

Copy link
Contributor

@bziondik bziondik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

@krampstudio krampstudio merged commit 03ca8c3 into develop Jul 5, 2022
@krampstudio krampstudio deleted the fix/enable-babel-updates branch July 5, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants