Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMAKE_INSTALL_LIBDIR
is allowed to be an absolute path as per CMake docs. This patch changes the build script to useCMAKE_INSTALL_FULL_LIBDIR
instead, and stops using the prefix detection code (many other libraries, such as LLVM, have done so already as it's quite finicky in practice due to absolute dirs being allowed).If you want to preserve backwards compatibility for setting
OATPP_MODULE_LIBDIR
, you can take any other approach (like not appending it to install prefix if it's an absolute dir). Absolute dirs are definitely used in the wild, at least on NixOS (where it's necessary due to packages being allowed to have multiple outputs - e.g. one path for headers, one path for libraries, one path for binaries)