Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow absolute GNU install dirs #813

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chayleaf
Copy link

@chayleaf chayleaf commented Aug 13, 2023

CMAKE_INSTALL_LIBDIR is allowed to be an absolute path as per CMake docs. This patch changes the build script to use CMAKE_INSTALL_FULL_LIBDIR instead, and stops using the prefix detection code (many other libraries, such as LLVM, have done so already as it's quite finicky in practice due to absolute dirs being allowed).

If you want to preserve backwards compatibility for setting OATPP_MODULE_LIBDIR, you can take any other approach (like not appending it to install prefix if it's an absolute dir). Absolute dirs are definitely used in the wild, at least on NixOS (where it's necessary due to packages being allowed to have multiple outputs - e.g. one path for headers, one path for libraries, one path for binaries)

@lganzzzo
Copy link
Member

Hello @chayleaf ,

Thanks for the PR!
Looks good to me.

However, before merging it we have to make same changes for all other oatpp modules:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants