Add format attribute to endpoint info #875
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lganzzzo
reviewed
Oct 20, 2023
| * set context ptr | ||
| * @param contextPtr | ||
| */ | ||
| void setContextPtr(void* contextPtr); |
There was a problem hiding this comment.
Since this PR concerns mapper only - let us not add additional methods to ConsistentOutputStream.
Instead, let's pass some kind of context object directly to the serializer's serialize(stream, value, <context>); method.
| @@ -247,6 +247,7 @@ void Serializer::serializeObject(Serializer* serializer, | |||
| (first) ? first = false : stream->writeSimple(",", 1); | |||
| serializeString(stream, field->name, static_cast<v_buff_size>(std::strlen(field->name)), serializer->m_config->escapeFlags); | |||
| stream->writeSimple(":", 1); | |||
| stream->setContextPtr(&field->info); | |||
| serializer->serialize(stream, value); | |||
There was a problem hiding this comment.
Let's pass context directly to serialize method
|
Please note that this PR most probably will also be postponed due to the new functionality planned - see #879 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #608