configure traffic policy for svc #190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change add option to configure traffic policy for the service. It is backward compatible and will not change the default behavior.
tomkukral
force-pushed
the
traffic-policy
branch
from
df70fae
to
33f67c0
Compare
There was a problem hiding this comment.
These new parameters must be documented here:
https://github.com/oauth2-proxy/manifests/blob/main/helm/oauth2-proxy/README.md#configuration
| # configure externalTrafficPolicy | ||
| externalTrafficPolicy: | ||
| # configure internalTrafficPolicy | ||
| internalTrafficPolicy: |
There was a problem hiding this comment.
Please add Cluster as default.
| @@ -128,6 +128,11 @@ service: | |||
| appProtocol: http | |||
| annotations: {} | |||
| # foo.io/bar: "true" | |||
| # configure externalTrafficPolicy | |||
| externalTrafficPolicy: | |||
There was a problem hiding this comment.
Please add Cluster as default.
helm/oauth2-proxy/Chart.yaml
Outdated
| @@ -1,5 +1,5 @@ | |||
| name: oauth2-proxy | |||
| version: 7.2.0 | |||
| version: 7.3.0 | |||
There was a problem hiding this comment.
artifacthub.io/changes needs to be changed.
|
@tomkukral, could you please take a look and try to move forward with the PR? |
|
@tomkukral I tried to change the PR, but it's impossible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change add option to configure traffic policy for the service. It is backward compatible and will not change the default behavior.