qulice back to 0.22

objectionary · Mar 7, 2024 · ae53efd · ae53efd
1 parent a2be0ac
commit ae53efd
Show file tree

Hide file tree

Showing 38 changed files with 52 additions and 49 deletions.
diff --git a/eo-maven-plugin/src/main/java/org/eolang/maven/AssembleMojo.java b/eo-maven-plugin/src/main/java/org/eolang/maven/AssembleMojo.java
@@ -113,17 +113,17 @@ public final class AssembleMojo extends SafeMojo {
 
     /**
      * Pull again even if the .eo file is already present?
-     * @checkstyle MemberNameCheck (7 lines)
      * @since 0.10.0
+     * @checkstyle MemberNameCheck (7 lines)
      */
     @Parameter(property = "eo.overWrite", required = true, defaultValue = "false")
     private boolean overWrite;
 
     /**
      * Track optimization steps into intermediate XML files?
      *
-     * @checkstyle MemberNameCheck (7 lines)
      * @since 0.24.0
+     * @checkstyle MemberNameCheck (7 lines)
      */
     @SuppressWarnings("PMD.LongVariable")
     @Parameter(property = "eo.trackOptimizationSteps", required = true, defaultValue = "false")
@@ -139,25 +139,25 @@ public final class AssembleMojo extends SafeMojo {
 
     /**
      * Skip artifact with the version 0.0.0.
-     * @checkstyle MemberNameCheck (7 lines)
      * @since 0.9.0
+     * @checkstyle MemberNameCheck (7 lines)
      */
     @Parameter(property = "eo.skipZeroVersions", required = true, defaultValue = "true")
     private boolean skipZeroVersions;
 
     /**
      * Shall we discover JAR artifacts for .EO sources?
-     * @checkstyle MemberNameCheck (7 lines)
      * @since 0.12.0
+     * @checkstyle MemberNameCheck (7 lines)
      */
     @Parameter(property = "eo.discoverSelf", required = true, defaultValue = "false")
     private boolean discoverSelf;
 
     /**
      * Fail resolution process on conflicting dependencies.
      *
-     * @checkstyle MemberNameCheck (7 lines)
      * @since 1.0
+     * @checkstyle MemberNameCheck (7 lines)
      */
     @Parameter(property = "eo.ignoreVersionConflicts", required = true, defaultValue = "false")
     @SuppressWarnings("PMD.LongVariable")
@@ -196,9 +196,9 @@ public final class AssembleMojo extends SafeMojo {
     /**
      * If set to TRUE, the exception on exit will be printed in details
      * to the log.
+     * @since 0.29.0
      * @checkstyle MemberNameCheck (7 lines)
      * @checkstyle VisibilityModifierCheck (10 lines)
-     * @since 0.29.0
      */
     @Parameter(property = "eo.unrollExitError")
     @SuppressWarnings("PMD.ImmutableField")

diff --git a/eo-maven-plugin/src/main/java/org/eolang/maven/BinarizeMojo.java b/eo-maven-plugin/src/main/java/org/eolang/maven/BinarizeMojo.java
@@ -39,8 +39,8 @@
 /**
  * Compile binaries.
  *
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  * @since 0.1
+ * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 @Mojo(
     name = "binarize",

diff --git a/eo-maven-plugin/src/main/java/org/eolang/maven/BinarizeParse.java b/eo-maven-plugin/src/main/java/org/eolang/maven/BinarizeParse.java
@@ -50,8 +50,8 @@
 /**
  * Parse rust inserts.
  *
- * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  * @since 0.1
+ * @checkstyle ClassDataAbstractionCouplingCheck (500 lines)
  */
 @SuppressWarnings("PMD.LongVariable")
 public final class BinarizeParse {

diff --git a/eo-maven-plugin/src/main/java/org/eolang/maven/DemandMojo.java b/eo-maven-plugin/src/main/java/org/eolang/maven/DemandMojo.java
@@ -44,8 +44,8 @@ public final class DemandMojo extends SafeMojo {
 
     /**
      * List of object names to add.
-     * @checkstyle MemberNameCheck (7 lines)
      * @since 0.17.0
+     * @checkstyle MemberNameCheck (7 lines)
      */
     @Parameter(required = true)
     private List<String> objects;

diff --git a/eo-maven-plugin/src/main/java/org/eolang/maven/OptimizeMojo.java b/eo-maven-plugin/src/main/java/org/eolang/maven/OptimizeMojo.java
@@ -78,8 +78,8 @@ public final class OptimizeMojo extends SafeMojo {
     /**
      * Track optimization steps into intermediate XML files?
      *
-     * @checkstyle MemberNameCheck (7 lines)
      * @since 0.24.0
+     * @checkstyle MemberNameCheck (7 lines)
      */
     @SuppressWarnings("PMD.LongVariable")
     @Parameter(property = "eo.trackOptimizationSteps", required = true, defaultValue = "false")

diff --git a/eo-maven-plugin/src/main/java/org/eolang/maven/PlaceMojo.java b/eo-maven-plugin/src/main/java/org/eolang/maven/PlaceMojo.java
@@ -49,8 +49,8 @@
  * Take binary files from where ResolveMojo placed them and
  * copy to target/classes.
  *
- * @since 0.11
  * @see <a href="https://news.eolang.org/2022-10-19-placed-catalog.html">Place catalog</a>
+ * @since 0.11
  */
 @Mojo(
     name = "place",

diff --git a/eo-maven-plugin/src/main/java/org/eolang/maven/PullMojo.java b/eo-maven-plugin/src/main/java/org/eolang/maven/PullMojo.java
@@ -87,8 +87,8 @@ public final class PullMojo extends SafeMojo {
 
     /**
      * Pull again even if the .eo file is already present?
-     * @checkstyle MemberNameCheck (7 lines)
      * @since 0.10.0
+     * @checkstyle MemberNameCheck (7 lines)
      */
     @Parameter(property = "eo.overWrite", required = true, defaultValue = "false")
     private boolean overWrite;

diff --git a/eo-maven-plugin/src/main/java/org/eolang/maven/ResolveMojo.java b/eo-maven-plugin/src/main/java/org/eolang/maven/ResolveMojo.java
@@ -69,26 +69,26 @@ public final class ResolveMojo extends SafeMojo {
     /**
      * Skip artifact with the version 0.0.0.
      *
-     * @checkstyle MemberNameCheck (7 lines)
      * @since 0.9.0
+     * @checkstyle MemberNameCheck (7 lines)
      */
     @Parameter(property = "eo.skipZeroVersions", required = true, defaultValue = "true")
     private boolean skipZeroVersions;
 
     /**
      * Shall we discover JAR artifacts for .EO sources?
      *
-     * @checkstyle MemberNameCheck (7 lines)
      * @since 0.12.0
+     * @checkstyle MemberNameCheck (7 lines)
      */
     @Parameter(property = "eo.discoverSelf", required = true, defaultValue = "false")
     private boolean discoverSelf;
 
     /**
      * Fail resolution process on conflicting dependencies.
      *
-     * @checkstyle MemberNameCheck (7 lines)
      * @since 1.0
+     * @checkstyle MemberNameCheck (7 lines)
      */
     @Parameter(property = "eo.ignoreVersionConflicts", required = true, defaultValue = "false")
     @SuppressWarnings("PMD.LongVariable")

diff --git a/eo-maven-plugin/src/main/java/org/eolang/maven/SafeMojo.java b/eo-maven-plugin/src/main/java/org/eolang/maven/SafeMojo.java
@@ -123,9 +123,9 @@ abstract class SafeMojo extends AbstractMojo {
     /**
      * The path to a text file where paths of all added
      * .class (and maybe others) files are placed.
+     * @since 0.11.0
      * @checkstyle MemberNameCheck (7 lines)
      * @checkstyle VisibilityModifierCheck (10 lines)
-     * @since 0.11.0
      */
     @Parameter(
         property = "eo.placed",
@@ -144,9 +144,9 @@ abstract class SafeMojo extends AbstractMojo {
 
     /**
      * The path to a text file where paths of generated java files per EO program.
+     * @since 0.11.0
      * @checkstyle MemberNameCheck (7 lines)
      * @checkstyle VisibilityModifierCheck (10 lines)
-     * @since 0.11.0
      */
     @Parameter(
         property = "eo.transpiled",
@@ -157,8 +157,8 @@ abstract class SafeMojo extends AbstractMojo {
 
     /**
      * Mojo execution timeout in seconds.
-     * @checkstyle VisibilityModifierCheck (10 lines)
      * @since 0.28.12
+     * @checkstyle VisibilityModifierCheck (10 lines)
      */
     @Parameter(property = "eo.timeout")
     protected Integer timeout = Integer.MAX_VALUE;
@@ -174,9 +174,9 @@ abstract class SafeMojo extends AbstractMojo {
     /**
      * If set to TRUE, the exception on exit will be printed in details
      * to the log.
+     * @since 0.29.0
      * @checkstyle MemberNameCheck (7 lines)
      * @checkstyle VisibilityModifierCheck (10 lines)
-     * @since 0.29.0
      */
     @Parameter(property = "eo.unrollExitError")
     protected boolean unrollExitError = true;

diff --git a/eo-maven-plugin/src/main/java/org/eolang/maven/ShakeMojo.java b/eo-maven-plugin/src/main/java/org/eolang/maven/ShakeMojo.java
@@ -75,8 +75,8 @@ public final class ShakeMojo extends SafeMojo {
     /**
      * Track optimization steps into intermediate XML files?
      *
-     * @checkstyle MemberNameCheck (7 lines)
      * @since 0.24.0
+     * @checkstyle MemberNameCheck (7 lines)
      */
     @SuppressWarnings("PMD.LongVariable")
     @Parameter(property = "eo.trackOptimizationSteps", required = true, defaultValue = "false")

diff --git a/eo-maven-plugin/src/main/java/org/eolang/maven/UnplaceMojo.java b/eo-maven-plugin/src/main/java/org/eolang/maven/UnplaceMojo.java
@@ -58,17 +58,17 @@ public final class UnplaceMojo extends SafeMojo {
 
     /**
      * List of inclusion GLOB filters for unplacing (these files will be removed for sure).
-     * @since 0.24
      * @see <a href="https://news.eolang.org/2022-07-15-placing-and-unplacing.html">Placing and Unplacing in JAR Artifacts</a>
+     * @since 0.24
      * @checkstyle MemberNameCheck (7 lines)
      */
     @Parameter
     private Set<String> removeBinaries = new SetOf<>();
 
     /**
      * List of inclusion GLOB filters for placing (ONLY these files will stay).
-     * @since 0.24
      * @see <a href="https://news.eolang.org/2022-07-15-placing-and-unplacing.html">Placing and Unplacing in JAR Artifacts</a>
+     * @since 0.24
      * @checkstyle MemberNameCheck (7 lines)
      */
     @Parameter

diff --git a/eo-maven-plugin/src/main/java/org/eolang/maven/dependencies/DcsFake.java b/eo-maven-plugin/src/main/java/org/eolang/maven/dependencies/DcsFake.java
@@ -119,11 +119,14 @@ static Dependency runtimeDep() {
      */
     private static Dependency randDep() {
         final Random rand = new SecureRandom();
+        final String scope = new String[] {
+            "test", "compiled", "runtime",
+        }[rand.nextInt(3)];
         return DcsFake.dep(
             UUID.randomUUID().toString(),
             UUID.randomUUID().toString(),
             String.valueOf(Math.abs(rand.nextInt())),
-            new String[]{"test", "compiled", "runtime"}[rand.nextInt(3)]
+            scope
         );
     }
 

diff --git a/eo-maven-plugin/src/main/java/org/eolang/maven/objectionary/Objectionaries.java b/eo-maven-plugin/src/main/java/org/eolang/maven/objectionary/Objectionaries.java
@@ -56,7 +56,7 @@ public interface Objectionaries {
      *
      * @since 0.29.6
      */
-    class Fake implements Objectionaries {
+    final class Fake implements Objectionaries {
         /**
          * Default objectionary.
          */

diff --git a/eo-maven-plugin/src/main/java/org/eolang/maven/objectionary/Objectionary.java b/eo-maven-plugin/src/main/java/org/eolang/maven/objectionary/Objectionary.java
@@ -56,8 +56,8 @@ public interface Objectionary {
     /**
      * Objectionary with lambda-function Ctor-s for testing.
      *
-     * @checkstyle IllegalCatchCheck (150 lines)
      * @since 0.28.11
+     * @checkstyle IllegalCatchCheck (150 lines)
      */
     @SuppressWarnings("PMD.AvoidCatchingGenericException")
     final class Fake implements Objectionary {

diff --git a/eo-maven-plugin/src/test/java/org/eolang/maven/AssembleMojoTest.java b/eo-maven-plugin/src/test/java/org/eolang/maven/AssembleMojoTest.java
@@ -48,6 +48,7 @@
 /**
  * Test case for {@link AssembleMojo}.
  *
+ * @since 0.1
  * @todo #1602:30min Make up how to get rid of excessive usage of
  *  {@code ParseMojo.DIR}, {@code ResolveMojo.DIR} and so on. It would be nice
  *  to replace them with corresponding classes, or something similar
@@ -61,7 +62,6 @@
  *  from older repositories are not parsed successfully because of the presence of varargs there.
  *  So we need to make 2-3 releases and then refactor the test with more fresh versions. Don't
  *  forget to remove the puzzle.
- * @since 0.1
  */
 @ExtendWith(WeAreOnline.class)
 final class AssembleMojoTest {

diff --git a/eo-maven-plugin/src/test/java/org/eolang/maven/CatalogsTest.java b/eo-maven-plugin/src/test/java/org/eolang/maven/CatalogsTest.java
@@ -43,7 +43,7 @@
  * everything works fine it's important to run the tests many times.
  * @since 0.29.0
  */
-class CatalogsTest {
+final class CatalogsTest {
 
     /**
      * Number of cores on the running system.

diff --git a/eo-maven-plugin/src/test/java/org/eolang/maven/CleanMojoTest.java b/eo-maven-plugin/src/test/java/org/eolang/maven/CleanMojoTest.java
@@ -39,7 +39,7 @@
  *
  * @since 0.28.6
  */
-class CleanMojoTest {
+final class CleanMojoTest {
 
     @Test
     void cleansSuccessfully(@TempDir final Path temp) throws IOException {

diff --git a/eo-maven-plugin/src/test/java/org/eolang/maven/JavaFilesTest.java b/eo-maven-plugin/src/test/java/org/eolang/maven/JavaFilesTest.java
@@ -44,7 +44,7 @@
  *
  * @since 0.29
  */
-class JavaFilesTest {
+final class JavaFilesTest {
 
     /**
      * Parsed eo program from resources.

diff --git a/eo-maven-plugin/src/test/java/org/eolang/maven/LatexMojoTest.java b/eo-maven-plugin/src/test/java/org/eolang/maven/LatexMojoTest.java
@@ -34,7 +34,7 @@
  *
  * @since 0.29
  */
-class LatexMojoTest {
+final class LatexMojoTest {
 
     /**
      * Generate simple main.tex file from main.xmir file

diff --git a/eo-maven-plugin/src/test/java/org/eolang/maven/LogFormatTest.java b/eo-maven-plugin/src/test/java/org/eolang/maven/LogFormatTest.java
@@ -46,7 +46,7 @@
  */
 @Execution(ExecutionMode.SAME_THREAD)
 @SuppressWarnings("JTCOP.RuleAllTestsHaveProductionClass")
-class LogFormatTest {
+final class LogFormatTest {
 
     /**
      * Expected log message format.

diff --git a/eo-maven-plugin/src/test/java/org/eolang/maven/PhiMojoTest.java b/eo-maven-plugin/src/test/java/org/eolang/maven/PhiMojoTest.java
@@ -39,7 +39,7 @@
  * Test cases for {@link PhiMojo}.
  * @since 0.34.0
  */
-class PhiMojoTest {
+final class PhiMojoTest {
     @Test
     void createsFiles(@TempDir final Path temp) throws Exception {
         MatcherAssert.assertThat(

diff --git a/eo-maven-plugin/src/test/java/org/eolang/maven/UnphiMojoTest.java b/eo-maven-plugin/src/test/java/org/eolang/maven/UnphiMojoTest.java
@@ -53,7 +53,7 @@
  * Test cases for {@link UnphiMojo}.
  * @since 0.34.0
  */
-class UnphiMojoTest {
+final class UnphiMojoTest {
     @Test
     void createsFile(@TempDir final Path temp) throws Exception {
         new HmBase(temp).save(

diff --git a/eo-maven-plugin/src/test/java/org/eolang/maven/VerifyMojoTest.java b/eo-maven-plugin/src/test/java/org/eolang/maven/VerifyMojoTest.java
@@ -57,7 +57,7 @@
  *  error Assertion since now it is hard to get why it failed.
  */
 @SuppressWarnings({"PMD.AvoidDuplicateLiterals", "PMD.TooManyMethods"})
-class VerifyMojoTest {
+final class VerifyMojoTest {
 
     @Test
     void doesNotFailWithNoErrorsAndWarnings(@TempDir final Path temp) {

diff --git a/...aven-plugin/src/test/java/org/eolang/maven/dependencies/DcsEachWithoutTransitiveTest.java b/...aven-plugin/src/test/java/org/eolang/maven/dependencies/DcsEachWithoutTransitiveTest.java
@@ -38,7 +38,7 @@
  *
  * @since 0.30
  */
-class DcsEachWithoutTransitiveTest {
+final class DcsEachWithoutTransitiveTest {
 
     @Test
     void failsIfHasTransitiveDependencies() {

diff --git a/eo-maven-plugin/src/test/java/org/eolang/maven/hash/ChCachedTest.java b/eo-maven-plugin/src/test/java/org/eolang/maven/hash/ChCachedTest.java
@@ -33,7 +33,7 @@
  *
  * @since 0.28.11
  */
-class ChCachedTest {
+final class ChCachedTest {
 
     @Test
     void cachesHashAndInvokesDelegateOnlyOnce() {

diff --git a/eo-maven-plugin/src/test/java/org/eolang/maven/hash/ChNarrowTest.java b/eo-maven-plugin/src/test/java/org/eolang/maven/hash/ChNarrowTest.java
@@ -35,7 +35,7 @@
  *
  * @since 0.28.11
  */
-class ChNarrowTest {
+final class ChNarrowTest {
 
     @ParameterizedTest
     @CsvSource({

diff --git a/eo-maven-plugin/src/test/java/org/eolang/maven/hash/ChTextTest.java b/eo-maven-plugin/src/test/java/org/eolang/maven/hash/ChTextTest.java
@@ -41,7 +41,7 @@
  *
  * @since 0.28.11
  */
-class ChTextTest {
+final class ChTextTest {
 
     /**
      * Test file path in temp dir.

diff --git a/eo-maven-plugin/src/test/java/org/eolang/maven/latex/LatexTemplateTest.java b/eo-maven-plugin/src/test/java/org/eolang/maven/latex/LatexTemplateTest.java
@@ -32,7 +32,7 @@
  *
  * @since 0.30
  */
-class LatexTemplateTest {
+final class LatexTemplateTest {
 
     /**
      * Check the full template.

diff --git a/eo-maven-plugin/src/test/java/org/eolang/maven/name/OnSwapTest.java b/eo-maven-plugin/src/test/java/org/eolang/maven/name/OnSwapTest.java
@@ -33,7 +33,7 @@
  *
  * @since 0.29.6
  */
-class OnSwapTest {
+final class OnSwapTest {
     /**
      * First.
      */