1319 mark unplaced #1330
Closed
1319 mark unplaced #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yegor256 idk why but qulice fails with IllegalArgumentException here |
|
@OlesiaSub Does it pass locally? |
|
@mximp no |
|
It gave me warnings for lines 67-74 in PlaceMojoTest, I fixed them and got this error. |
|
@OlesiaSub report this to qulice project, we'll fix it there |
Graur
suggested changes
Oct 28, 2022
|
@OlesiaSub do you still experience issues here? |
|
@mximp I am fixing what Andrew advised right now) working on it |
mximp
reviewed
Nov 9, 2022
eo-maven-plugin/src/test/java/org/eolang/maven/PlaceMojoTest.java
Outdated
Show resolved
Hide resolved
…-mark-unplaced
…-mark-unplaced
…into 1319-mark-unplaced
|
@mximp apparently it does not pass here but passes locally... idk what to do, because it fails on something which is not related to my changes |
Merged
|
@OlesiaSub I've raised #1459 to check if it can be built successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1319