New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce code duplication down to 16 lines per piece #2920
Merged
rultor
merged 7 commits into
objectionary:master
from
c71n93:2863-reduce-code-duplication-16
Mar 11, 2024
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
85ce4c3
#2863 replace anonymous class by single implementation to reduce code…
c71n93 333e32f
#2863 fix qulice warnings
c71n93 153aeb9
#2863 create additional object for test to reduce code duplication
c71n93 3be2745
#2863 use dirty hacks to reduce code duplication
c71n93 0d5bbfb
#2863 fix documentation
c71n93 80f0434
#2863 fix documentation again
c71n93 6b317f8
#2863 slightly change the messages
c71n93 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -189,20 +189,13 @@ private static ConcurrentHashMap<String, String> load(final Path src) throws IOE | |
final Object result = map.readObject(); | ||
if (result.getClass() != ConcurrentHashMap.class) { | ||
throw new ClassCastException( | ||
String.format( | ||
"Object inside %s has wrong class %s", | ||
src, | ||
result.getClass() | ||
) | ||
String.format("Object inside %s has wrong class %s", src, result.getClass()) | ||
); | ||
} | ||
return (ConcurrentHashMap<String, String>) result; | ||
} catch (final ClassNotFoundException exc) { | ||
throw new IllegalArgumentException( | ||
String.format( | ||
"File %s contains invalid data", | ||
src | ||
), | ||
String.format("File %s contains invalid data", src), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @c71n93 same here: maybe it's better to slightly change the message? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
exc | ||
); | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c71n93 maybe it's better to slightly change the message?