#275: Update copyright year and GHA to check year #282
Conversation
|
@slry looks good, but do we really need a separate |
|
@yegor256 done. |
|
@yegor256 please, take a look at changes, we may merge it. |
|
@maxonfjvipon please, help us review this one |
test/test_mvnw.js
Outdated
There was a problem hiding this comment.
@slry why do we need these changes?
There was a problem hiding this comment.
I guess, my IDE accidentally formatted this file, will revert this one
|
@slry before actual review we need all GHA checks are green |
|
@maxonfjvipon I pulled updates from master and it passed markdownlint GHA But some of the build actions are failing because GHA cannot find Node of version 12 for arm64 Error: Unable to find Node version '12' for platform darwin and architecture arm64.I do not think this is the problem with this PR |
|
@slry you're right, but we won't be able merge your PR without these checks. You either should try to fix it, or wait until it's resolved by someone else in other PR |
|
@maxonfjvipon seems like this issue relates to this post Right now node12 is not supported by MacOS ARM64, using node16 could solve this issue What do you think? |
|
@slry let's try |
|
@maxonfjvipon I fixed macos problem, but tests still do not pass It seems like some of the npm packages do not support node12 and requires >=node16 /home/runner/work/eoc/eoc/node_modules/commander/lib/command.js:380
eOrNameAndArgs = enableOrNameAndArgs ?? 'help [command]';
^
SyntaxError: Unexpected token '?'
at wrapSafe (internal/modules/cjs/loader.js:915:16)
at Module._compile (internal/modules/cjs/loader.js:963:27)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
at Module.load (internal/modules/cjs/loader.js:863:32)
at Function.Module._load (internal/modules/cjs/loader.js:708:14)
at Module.require (internal/modules/cjs/loader.js:887:19)
at require (internal/modules/cjs/helpers.js:74:18)
at Object.<anonymous> (/home/runner/work/eoc/eoc/node_modules/commander/index.js:2:21)
at Module._compile (internal/modules/cjs/loader.js:999:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
Error: Process completed with exit code 1.UPD: I also checked |
|
@slry you're right. |
|
@maxonfjvipon now tests failing on Windows machine, I assume it cannot parse linux commands (maybe removing \ will fix it...) - run: |
cd itest
p=0.36.0
t=0.36.0
node ../src/eoc.js "--parser=$p" "--home-tag=$t" --batch \
dataize program
node ../src/eoc.js "--parser=$p" "--home-tag=$t" --alone \
--batch dataize program
node ../src/eoc.js clean
node ../src/eoc.js "--parser=$p" "--home-tag=$t" --batch \
testGHA output: ParserError: D:\a\_temp\ff659728-8805-4818-afa3-684a0463d1c4.ps1:8
Line |
8 | --batch dataize program
| ~
| Missing expression after unary operator '--'.
Error: Process completed with exit code 1.UPD: also I think there is also a problem with using environment variables in Windows |
|
@maxonfjvipon @yegor256 please approve this changes |
| node: [12, 16] | ||
| node: [14, 16] | ||
| exclude: | ||
| - os: macos-latest |
There was a problem hiding this comment.
@slry even Node 14 is not supported on MacOS?
There was a problem hiding this comment.
@maxonfjvipon I have tested it, unfortunately its not...
| - uses: actions/checkout@v4 | ||
| - name: Run check | ||
| run: | | ||
| bash - << 'SCRIPT' |
There was a problem hiding this comment.
@slry I can't understand, why do you need to run Bash script through this SCRIPT file? can't you just directly use the text?
There was a problem hiding this comment.
@yegor256 this script just do not work in yaml for some reason, so this is a workaround I found
In this PR I updated the copyright year of MIT license and added Workflow that runs script to check MIT license year on push and pull request
@yegor256, please take a look
Closes #275
PR-Codex overview
This PR updates the workflow files for integration testing and copyright check. It modifies the OS and Node versions, adds exclusion for macOS, and enhances the copyright check script.
Detailed summary