Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showing reference and current images along with the diff result #311

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Muritavo
Copy link

@Muritavo Muritavo commented Mar 1, 2021

This PR enables a feature requested by #144 as it's useful for when comparing complex UI changes.

What does it change:

  • Added a new property called includeReferenceOnDiff (default: false)
  • When the property is enabled, the reference image and the current images are concatenated side by side along with the diff result.

Currently is set as draft because it needs the following adjustments:

Make the property work on the other two diff engines, if someone want to do it, fell free to contribute to this PR as well

@Muritavo Muritavo changed the title Feature/diff with reference Showing reference and current images along with the diff result Mar 1, 2021
@Muritavo
Copy link
Author

Muritavo commented Mar 1, 2021

Adding here so it is documented:

For the GraphicsMagick library there is a method montage, that combines multiple images side by side.

As for the looks-same library, the createDiff without diff property can be used to manually write the file to disk, with the other references

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant