Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Amazon IVS service #10634

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

palana
Copy link
Contributor

@palana palana commented May 3, 2024

This PR depends on #10543

Description

Add Amazon IVS service with behavior similar to Twitch, for customers of Amazon IVS and their users

Motivation and Context

Currently users of Amazon IVS customers have to use the custom service entry and enter both a URL and their stream key; with multitrack video they'd also have to enter a config URL (which is currently not exposed in the custom service UI)

With these changes users will generally only have to enter their stream key (and select "Auto (RTMPS, Recommended)" or "Auto (RTMP)" depending on whichever the Amazon IVS customer wants their users to use)

How Has This Been Tested?

Tested using various IVS channels created for testing purposes, some of which were allowlisted for multitrack video

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@palana palana changed the title Ruwen/add amazon ivs service Add Amazon IVS service May 3, 2024
@palana palana force-pushed the ruwen/add-amazon-ivs-service branch from cbc521c to 3d5252c Compare May 3, 2024 15:20
@RytoEX RytoEX self-assigned this May 3, 2024
@WizardCM WizardCM added Services These are modifications to the Service list and are not tied to the release schedule Enhancement Improvement to existing functionality labels May 5, 2024
Copy link
Member

@RytoEX RytoEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

plugins/rtmp-services/data/services.json Outdated Show resolved Hide resolved
@RytoEX RytoEX force-pushed the ruwen/add-amazon-ivs-service branch from aa27260 to d7f5c3f Compare May 21, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to existing functionality Services These are modifications to the Service list and are not tied to the release schedule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants